Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CI: enable sqlite system tests #17954

Merged
merged 1 commit into from Apr 12, 2023
Merged

CI: enable sqlite system tests #17954

merged 1 commit into from Apr 12, 2023

Conversation

edsantiago
Copy link
Collaborator

In setup, write a containers.conf.d file with db_backend
as specified in .cirrus.yml.

This is actually much scarier and more achy-breaky than
merely "sqlite system tests": it enables sqlite in e2e
tests. ("But wait, we already do that!" -- no, not really.
sqlite in e2e is being done via --db-backend option, and
some podman commands in e2e do not use the standard options.
See #17904.

This is unlikely to get merged any time soon (March, maybe
even April) because sqlite is still too fragile; this will
trigger more flakes than are currently acceptable. Also,
the nasty auto-update flake seems to trigger much more
reliably with sqlite. We need that one fixed.

Signed-off-by: Ed Santiago santiago@redhat.com

None

@openshift-ci openshift-ci bot added release-note-none do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. labels Mar 28, 2023
@edsantiago
Copy link
Collaborator Author

Marked WIP because I'm going to be repeatedly running tests, and waiting for #17937 and #17953, then repeatedly running more tests.

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Mar 28, 2023
@edsantiago edsantiago force-pushed the sqlite_containersconf branch 2 times, most recently from c165b2e to 8b43963 Compare March 29, 2023 13:48
@edsantiago
Copy link
Collaborator Author

heads-up, github CI reporting seems to be stalled. Job is done, all green, but as of the moment I write this github is still showing jobs queued.

@edsantiago
Copy link
Collaborator Author

@cevich this job finished (green) many hours ago. Is there any way to tell Github to catch up, or do we have to resubmit all jobs?

@cevich
Copy link
Member

cevich commented Mar 29, 2023

Whoa, that's weird. I don't remember ever seeing that behavior before. Looking at the timer, it's going on 6-hours, so I'd bet it will never be marked as completed. Since clearly they're all green, I would just ask for this to be manually merged. Unless you think re-running would be faster 😞

@edsantiago
Copy link
Collaborator Author

I don't mind repushing - this is a scary PR, and more testing is good. It's just, all PRs from this morning are stuck because of the github hiccup. I was wondering if there was a fix.

@edsantiago edsantiago mentioned this pull request Mar 29, 2023
Closed
@edsantiago
Copy link
Collaborator Author

Blocked by #17904

@edsantiago edsantiago force-pushed the sqlite_containersconf branch 4 times, most recently from d940c9f to 8d81445 Compare April 5, 2023 13:23
@edsantiago edsantiago mentioned this pull request Apr 5, 2023
Merged
@edsantiago edsantiago force-pushed the sqlite_containersconf branch 2 times, most recently from f01edea to cd917d6 Compare April 6, 2023 20:09
@edsantiago edsantiago mentioned this pull request Apr 7, 2023
Draft
@edsantiago edsantiago force-pushed the sqlite_containersconf branch 3 times, most recently from 5f4c1ca to 3204f99 Compare April 11, 2023 15:40
@edsantiago edsantiago mentioned this pull request Apr 11, 2023
Open
@edsantiago edsantiago force-pushed the sqlite_containersconf branch 2 times, most recently from 6cda2f3 to fe5855f Compare April 12, 2023 10:56
@edsantiago
CI: enable sqlite system tests
f95276b 
In setup, write a containers.conf.d file with db_backend
as specified in .cirrus.yml.

This is actually much scarier and more achy-breaky than
merely "sqlite system tests": it enables sqlite in e2e
tests. ("But wait, we already do that!" -- no, not really.
sqlite in e2e is being done via --db-backend option, and
some podman commands in e2e do not use the standard options.
See containers#17904.

This is unlikely to get merged any time soon (March, maybe
even April) because sqlite is still too fragile; this will
trigger more flakes than are currently acceptable. Also,
the nasty auto-update flake seems to trigger much more
reliably with sqlite. We need that one fixed.

Signed-off-by: Ed Santiago <santiago@redhat.com>
@edsantiago edsantiago mentioned this pull request Apr 12, 2023
Closed
@edsantiago edsantiago mentioned this pull request Apr 12, 2023
Closed
@edsantiago edsantiago changed the title WIP: CI: enable sqlite system tests CI: enable sqlite system tests Apr 12, 2023
@openshift-ci openshift-ci bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Apr 12, 2023
@edsantiago
Copy link
Collaborator Author

@cevich @containers/podman-maintainers this is ready to go. I hand-checked all logs, all flakes are the usual ones.

Luap99
Luap99 reviewed Apr 12, 2023
View reviewed changes
Copy link
Member

@Luap99 Luap99 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

vrothberg
vrothberg approved these changes Apr 12, 2023
View reviewed changes
Copy link
Member

@vrothberg vrothberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/hold

Waiting for a head nod from @cevich

@openshift-ci openshift-ci bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Apr 12, 2023
@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Apr 12, 2023
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Apr 12, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: edsantiago, vrothberg

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [edsantiago,vrothberg]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@cevich
Copy link
Member

cevich commented Apr 12, 2023

LGTM

@cevich
Copy link
Member

cevich commented Apr 12, 2023

/hold cancel

@openshift-ci openshift-ci bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Apr 12, 2023
@openshift-merge-robot openshift-merge-robot merged commit 5294864 into containers:main Apr 12, 2023
69 checks passed
@edsantiago edsantiago deleted the sqlite_containersconf branch April 12, 2023 20:14
@edsantiago edsantiago mentioned this pull request Apr 25, 2023
Closed
This was referenced May 2, 2023
Closed
Closed
@github-actions github-actions bot added the locked - please file new issue/PR Assist humans wanting to comment on an old issue or PR with locked comments. label Sep 1, 2023
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Sep 1, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@Luap99 Luap99 Luap99 left review comments

@vrothberg vrothberg vrothberg approved these changes

Assignees

@vrothberg vrothberg

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. locked - please file new issue/PR Assist humans wanting to comment on an old issue or PR with locked comments. release-note-none
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@edsantiago @cevich @vrothberg @Luap99 @openshift-merge-robot