[v4.4.1-rhel] compat: /auth: parse server address correctly #18006
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Use `auth.Login` as `podman login` does which parses and normalizes the input addresses correctly, especially for docker.io. This Cherry Picks containers#17581 and brings in necessary changes to run_test.go from i containers@5f86fae Addreses: https://bugzilla.redhat.com/show_bug.cgi?id=2183601 and https://bugzilla.redhat.com/show_bug.cgi?id=2183602 for the RHEL 8.8 and 9.2 ZeroDay The original Fixed: containers#17571 Signed-off-by: Valentin Rothberg <vrothberg@redhat.com> Signed-off-by: tomsweeneyredhat <tsweeney@redhat.com>
openshift-ci
bot
added
release-note
approved
github-actions
bot
added
the
kind/api-change
|
@flouthoc and @vrothberg PTAL |
|
@giuseppe PTAL |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: flouthoc, TomSweeneyRedHat, vrothberg The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
/lgtm |
openshift-merge-robot
merged commit 05037d3
into
containers:v4.4.1-rhel
56 checks passed
github-actions
bot
added
the
locked - please file new issue/PR
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use
auth.Loginaspodman logindoes which parses and normalizes the input addresses correctly, especially for docker.io.This Cherry Picks #17581 and brings in necessary changes to run_test.go from i
5f86fae
Addreses: https://bugzilla.redhat.com/show_bug.cgi?id=2183601 and https://bugzilla.redhat.com/show_bug.cgi?id=2183602 for the RHEL 8.8 and 9.2 ZeroDay
The original Fixed: #17571
Does this PR introduce a user-facing change?