Fixes #18907, pass in correct cwd value for hooks exe #18921
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
openshift-ci
bot
added
release-note
do-not-merge/work-in-progress
fangpenlin
changed the title
fangpenlin
changed the title
openshift-ci
bot
removed
the
do-not-merge/work-in-progress
fangpenlin
force-pushed
the
fix-18907-set-correct-cwd-for-poststop-hook-exe
branch
from
0e32cc7
to
3e95216
Compare
Signed-off-by: Fang-Pen Lin <hello@fangpenlin.com>
fangpenlin
force-pushed
the
fix-18907-set-correct-cwd-for-poststop-hook-exe
branch
from
3e95216
to
dd81f7a
Compare
|
Updated PR with the new methods in common. Still waiting for a new common release. Do I need to add vendor changes in this PR by the way? |
|
No you do not have to wait for the vendoring. LGTM |
openshift-ci
bot
added
the
approved
|
@containers/podman-maintainers PTAL |
|
@vrothberg @Luap99 PTAL |
|
@giuseppe PTAL |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: fangpenlin, rhatdan, vrothberg The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
github-actions
bot
added
the
locked - please file new issue/PR
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #18907
This PR depends on containers/common#1514 to be merged. Sorry first time contributor, I am not sure what's the correct workflow to make changes in upstream
commonrepo. I assume I should create a new PR in common repo first, then wait for a new release fromcommonthen update the vendor file in this repo to make it depends on the changes I made in common?Does this PR introduce a user-facing change?