Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update vendor containers/(common, buildah, image, storage) #19187

Merged
merged 1 commit into from
Jul 15, 2023
Merged

Update vendor containers/(common, buildah, image, storage) #19187

merged 1 commit into from
Jul 15, 2023

Conversation

rhatdan
Copy link
Member

@rhatdan rhatdan commented Jul 10, 2023

Does this PR introduce a user-facing change?

None

@openshift-ci openshift-ci bot added release-note-none approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Jul 10, 2023
@flouthoc flouthoc added the bloat_approved Approve a PR in which binary file size grows by over 50k label Jul 11, 2023
flouthoc
flouthoc approved these changes Jul 11, 2023
View reviewed changes
Copy link
Collaborator

@flouthoc flouthoc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM does this needs bloat_approved

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jul 11, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: flouthoc, rhatdan

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@rhatdan rhatdan force-pushed the VENDOR branch 3 times, most recently from b9cef32 to 61bd9e3 Compare July 13, 2023 17:22
@mheon
Copy link
Member

mheon commented Jul 13, 2023

LGTM once tests go green

@rhatdan rhatdan added lgtm Indicates that a PR is ready to be merged. and removed lgtm Indicates that a PR is ready to be merged. labels Jul 14, 2023
@rhatdan
Update vendor containers/(common, buildah, image, storage)
13a9500 
Signed-off-by: Daniel J Walsh <dwalsh@redhat.com>
@rhatdan rhatdan added the lgtm Indicates that a PR is ready to be merged. label Jul 15, 2023
@openshift-merge-robot openshift-merge-robot merged commit 0745fe8 into containers:main Jul 15, 2023
88 checks passed
@Luap99 Luap99 mentioned this pull request Jul 19, 2023
Open
@github-actions github-actions bot added the locked - please file new issue/PR Assist humans wanting to comment on an old issue or PR with locked comments. label Oct 14, 2023
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Oct 14, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@flouthoc flouthoc flouthoc approved these changes

Assignees
No one assigned
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. bloat_approved Approve a PR in which binary file size grows by over 50k lgtm Indicates that a PR is ready to be merged. locked - please file new issue/PR Assist humans wanting to comment on an old issue or PR with locked comments. release-note-none
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@rhatdan @mheon @flouthoc @openshift-merge-robot