Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CI:DOCS] update --network docs #19225

Merged
merged 2 commits into from Jul 13, 2023

Conversation

Luap99
Copy link
Member

@Luap99 Luap99 commented Jul 13, 2023

docs: podman run --network mention comma separted names

This syntax was used prior to 4.0 and is still supported for backwards
compatibility.
Fixes #19089

docs: podman-build --network add slirp and pasta

Support was added in buildah some weeks ago. [1]

[1] containers/buildah#4877

Does this PR introduce a user-facing change?

None

This syntax was used prior to 4.0 and is still supported for backwards
compatibility.

Fixes containers#19089

Signed-off-by: Paul Holzinger <pholzing@redhat.com>
Support was added in buildah some weeks ago. [1]

[1] containers/buildah#4877

Signed-off-by: Paul Holzinger <pholzing@redhat.com>
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jul 13, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Luap99

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jul 13, 2023
@baude
Copy link
Member

baude commented Jul 13, 2023

lgtm

@rhatdan
Copy link
Member

rhatdan commented Jul 13, 2023

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Jul 13, 2023
@openshift-merge-robot openshift-merge-robot merged commit 2657185 into containers:main Jul 13, 2023
34 checks passed
@Luap99 Luap99 deleted the network-doc branch July 14, 2023 07:35
@ashley-cui ashley-cui added the 4.6 label Jul 20, 2023
@github-actions github-actions bot added the locked - please file new issue/PR Assist humans wanting to comment on an old issue or PR with locked comments. label Oct 19, 2023
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Oct 19, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. locked - please file new issue/PR Assist humans wanting to comment on an old issue or PR with locked comments. release-note-none
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Inconsistent behavior of --network option
5 participants