Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

inspect with network=none show SandboxKey netns path #19444

Merged
merged 1 commit into from
Jul 31, 2023

Conversation

Luap99
Copy link
Member

@Luap99 Luap99 commented Jul 31, 2023

We do not use any special netns path for the netns=none case, however callers that inspect that may still wish to join the netns path directly without extra work to figure out /proc/$pid/ns/net.

Fixes #16716

Does this PR introduce a user-facing change?

podman inspect will now show a `.NetworkSettings.SandboxKey` path for containers created with --net=none. 

@openshift-ci openshift-ci bot added release-note approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Jul 31, 2023
Copy link
Member

@vrothberg vrothberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jul 31, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Luap99, vrothberg

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@vrothberg
Copy link
Member

@containers/podman-maintainers PTAL

I restarted the flaked job. @edsantiago, I think my new sdnotify: healthy test is flaking. Does it show up in your data?

@edsantiago
Copy link
Collaborator

@vrothberg I don't see or remember any new sdnotify flakes, but will look at this one shortly.

We do not use any special netns path for the netns=none case, however
callers that inspect that may still wish to join the netns path directly
without extra work to figure out /proc/$pid/ns/net.

Fixes containers#16716

Signed-off-by: Paul Holzinger <pholzing@redhat.com>
@rhatdan
Copy link
Member

rhatdan commented Jul 31, 2023

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Jul 31, 2023
@openshift-merge-robot openshift-merge-robot merged commit 30ad23e into containers:main Jul 31, 2023
86 of 88 checks passed
@Luap99 Luap99 deleted the net-none-netns-path branch July 31, 2023 19:52
@RushingAlien
Copy link

RushingAlien commented Oct 18, 2023

Hello, This seems to not have landed to any stable/point releases?

I was checking on tagged releases to see if this commit is available, but i do not see it

@vrothberg
Copy link
Member

It landed in 4.7 (see the indication in the commit ada7188).

@github-actions github-actions bot added the locked - please file new issue/PR Assist humans wanting to comment on an old issue or PR with locked comments. label Jan 17, 2024
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jan 17, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. locked - please file new issue/PR Assist humans wanting to comment on an old issue or PR with locked comments. release-note
Projects
None yet
Development

Successfully merging this pull request may close these issues.

starting container with --network=none will not set up network namespace in filesystem
6 participants