-
Notifications
You must be signed in to change notification settings - Fork 2.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
inspect with network=none show SandboxKey netns path #19444
inspect with network=none show SandboxKey netns path #19444
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: Luap99, vrothberg The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
@containers/podman-maintainers PTAL I restarted the flaked job. @edsantiago, I think my new |
@vrothberg I don't see or remember any new |
We do not use any special netns path for the netns=none case, however callers that inspect that may still wish to join the netns path directly without extra work to figure out /proc/$pid/ns/net. Fixes containers#16716 Signed-off-by: Paul Holzinger <pholzing@redhat.com>
77f7e6b
to
ada7188
Compare
/lgtm |
30ad23e
into
containers:main
Hello, This seems to not have landed to any stable/point releases? I was checking on tagged releases to see if this commit is available, but i do not see it |
It landed in 4.7 (see the indication in the commit ada7188). |
We do not use any special netns path for the netns=none case, however callers that inspect that may still wish to join the netns path directly without extra work to figure out /proc/$pid/ns/net.
Fixes #16716
Does this PR introduce a user-facing change?