update CI images to 20230824 #19699
update CI images to 20230824 #19699
Conversation
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: Luap99 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-ci
bot
added
the
approved
|
weird Did we remove nc from the images? cc @cevich |
|
Not intentionally, and maybe an interesting note is this didn't fail in the slightly-older |
|
...oof, it gets more strange. The build log shows the magic happening: Maybe we need a |
|
Well it fails on both debian and fedora so this is really odd that both are breaking at the same time. |
|
Oh good point, I didn't notice the Fedora failures. Hrmmmm, that's concerning. Let's see what get_ci_vm.sh says... |
|
Nothing is installed: ("pandoc" and "libtool" are taken from the list in Of course by "nothing" I don't mean it literally, only that things-that-I-expect-to-be-installed are not-installed. |
|
Ok I assume the images are just broken then??? @cevich can you respin a new build. |
|
Pasta is broken:
@sbrivio-rh it looks like passt 0818 is broken, could you PTAL at the failing tests, and fix either pasta or the tests? |
Oops, yes, sorry, I guess pasta is broken, we get EINVAL while copying IPv4 routes. I'm having a look now, and tagging @dgibson in case I fall asl |
|
So, the change to report (most) errors on netlink operations made the failure here more evident, but it already existed. Previously rather than outright failing, we would simply have omitted copying certain routes from the container. Depending what those routes are the container might still operate more or less ok, or it might completely. The reason certain routes are seeing |
|
Correction: the issue described in the previous comment is only causing one of the podman failures. There's another bug causing some others, which @sbrivio-rh is looking into. |
|
So for this PR (which is not networking related?), it sounds like the "file-issue + skip tests" strategy is most appropriate. I'm going to merge containers/automation_images#297 as-is for now. But if some quick change is needed in the CI VM images, I'm happy to assist with that. |
As you wish -- I'm preparing new packages for Fedora and Debian at the moment, but it might take a while and if you have a way out... By the way, fixes are: https://passt.top/passt/commit/?id=5e4f7b92b0b0bf4724c505fa95fcae1526a8f88b |
|
There is nothing urgent in this PR. This is a simple cleanup of my previous work, we can wait until packages land in stable then rebuild images. |
Okay SGTM. @sbrivio-rh do you have a way to monitor those packages? Once they land in SID and Fedora updates-testing, I'm happy to roll new CI VM images and get them updated for Paul. |
I'm the maintainer for both -- I'll post here when they do. |
|
Fantastic, that will help a lot, thanks. |
|
changes LGTM, but the tests still need to be muscled over the line. |
|
Finally, passt-0.0~git20230823.a7e4bfb-1 reached Debian unstable, and passt-0^20230823.ga7e4bfb-1.fc38 is in Fedora's updates-testing. |
|
Great thanks, I'll start building fresh CI VM images. |
…sses Otherwise, we actually configure the address, but it's not usable because no local route is added by the kernel. Link: containers/podman#19699 Fixes: cfe7509 ("netlink: Use struct in_addr for IPv4 addresses, not bare uint32_t") Signed-off-by: Stefano Brivio <sbrivio@redhat.com>
Host routes can include a preferred source address (RTA_PREFSRC), which must be one of the host's addresses. However when using pasta with -a the namespace might be given a different address, not on the host. This seems to occur pretty routinely depending on the network configuration systems in place on the host. With --config-net we will try to copy host routes to the namespace. If one of those includes an RTA_PREFSRC, but the namespace doesn't have the host address, this will fail with -EINVAL, causing pasta to fail. Fix this by stripping off RTA_PREFSRC attributes from routes as we copy them to the namespace. This is by no means infallible, bit it should at least handle common cases for the time being. Link: https://bugs.passt.top/show_bug.cgi?id=71 Link: containers/podman#19699 (comment) Signed-off-by: David Gibson <david@gibson.dropbear.id.au> Signed-off-by: Stefano Brivio <sbrivio@redhat.com>
These images include the en_US.UTF-8 locale so we can remove the workaroud here in podman. Signed-off-by: Paul Holzinger <pholzing@redhat.com>
This reverts commit ed1f514. The en_US.UTF-8 locale is now added in the images at build time, containers/automation_images#295 Signed-off-by: Paul Holzinger <pholzing@redhat.com>
|
@cevich I used the image ID from containers/automation_images#298 @sbrivio-rh looks like fedora is working again but there is still a pasta issue on debian: |
|
Paul! You're suppose to be on PTO! Moving this issue to #19751 |
|
I am on PTO the next two weeks, so I still have an hour until PTO/weekend starts for me. |
|
No worries, I was just teasing. Enjoy your PTO 😄 |
Ugly as hell, but we keep breaking things otherwise, and I keep forgetting to run this manually (as long as it's based on my local Podman setup, that's the only alternative). We need to clone the Podman repository as distribution packages don't contain test scripts, typically. While at it, build the latest version which is what really matters. As we're planning anyway to revamp the test framework, I'd be inclined to just add this without too many thoughts, and have it as a nice-to-have requirement reminder for the new framework. Link: containers/podman#19699 Suggested-by: Paul Holzinger <pholzing@redhat.com> Signed-off-by: Stefano Brivio <sbrivio@redhat.com> Reviewed-by: David Gibson <david@gibson.dropbear.id.au>
github-actions
bot
added
the
locked - please file new issue/PR
includes the en_US.UTF-8 locale
Does this PR introduce a user-facing change?