Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

e2e: new ExitCleanly matcher #19802

Merged

Commits on Aug 30, 2023

  1. CI: e2e: fetch the standard system-test image

    Finally, after so many years, let's start using testimage:YYYYMMDD.
    Use it in place of LABELS_IMAGE, which nothing/nowhere was using.
    
    Signed-off-by: Ed Santiago <santiago@redhat.com>
    edsantiago committed Aug 30, 2023
    Configuration menu
    Copy the full SHA
    da1246d View commit details
    Browse the repository at this point in the history
  2. CI: e2e: new ginkgo matcher, ExitCleanly()

    Combined test for (exitcode == 0) && (nothing on stderr).
    Returns more useful diagnostic messages than the default:
    
      old: Expected N to equal 0
    
      new: Command failed with exit status N
      new: Unexpected warnings seen on stderr: "...."
    
    Signed-off-by: Ed Santiago <santiago@redhat.com>
    edsantiago committed Aug 30, 2023
    Configuration menu
    Copy the full SHA
    6cbd17c View commit details
    Browse the repository at this point in the history
  3. CI: e2e: first use of new ExitCleanly() matcher

    A nearly-trivial first effort to use the new ExitCleanly().
    Requires using the new CITEST_IMAGE (see prior commit)
    because nginx causes the tests to fail:
    
       [FAILED] Unexpected warnings seen on stderr: \
                level=warning \
                msg="HEALTHCHECK is not supported for OCI image format ...
    
    Oh, I also took the liberty of rewriting "play kube" -> "kube play".
    
    Signed-off-by: Ed Santiago <santiago@redhat.com>
    edsantiago committed Aug 30, 2023
    Configuration menu
    Copy the full SHA
    4082b67 View commit details
    Browse the repository at this point in the history