[CI:BUILD] packit: tag @containers/packit-build team on copr build failure #20061
Conversation
openshift-ci
bot
added
release-note-none
approved
openshift-ci
bot
added
the
do-not-merge/work-in-progress
|
This is pretty cool! TIL that this also works on copr builds, not just tests. Makes sense in hindsight 😁 |
lsm5
force-pushed
the
packit-fail-tag
branch
from
bb23f6e
to
a7464f1
Compare
openshift-ci
bot
removed
the
do-not-merge/work-in-progress
lsm5
force-pushed
the
packit-fail-tag
branch
from
a7464f1
to
9658aa0
Compare
|
@haircommander @saschagrunert ping, might be worth doing on conmon-rs too. PTAL. |
.packit.yaml
Outdated
| @@ -16,8 +16,10 @@ actions: | |||
| jobs: | |||
| - job: copr_build | |||
| trigger: pull_request | |||
| notifications: | |||
| failure_comment: | |||
| message: "Ephemeral COPR build failed. @lsm5 please check." | |||
There was a problem hiding this comment.
Can you create a GitHub Team or Organization and use that instead? Even if that group only has you in it.
There was a problem hiding this comment.
hmm, don't know if the packit feature works for teams but we can try. We'll also need something similar for the revdep failure tag @martinpitt
There was a problem hiding this comment.
It's not a feature of packit. You can specify whichever text you want in the notification. The @user is a GitHub feature. But I'm not sure if e.g. tagging the @cockpit-project org actually works (that would be way too big, just for testing -- if it works, sorry everyone for the noise!)
There was a problem hiding this comment.
@martinpitt maybe a cockpit team with the three of you would work? I created @containers/packit-build just now.
There was a problem hiding this comment.
@martinpitt i could even create a containers/cockpit-tests team if that works for you.
There was a problem hiding this comment.
Yup, I'm happy to handle the cockpit notifications separately. But I'm still not convinced that tagging a team actually works -- did anyone from the cockpit-project org actually get this notification? Please react with 👍 here if you did. Thanks
There was a problem hiding this comment.
@martinpitt I see both team and org mentions in your latest comment. To be clear, I haven't created any cockpit team in the containers org yet.
There was a problem hiding this comment.
@lsm5 I just asked my colleagues in @cockpit-project, and they did not get the notification (that also makes sense -- spam protection). So an org won't work. A team might, let me test that in cockpit-project/bots#5288 (comment)
There was a problem hiding this comment.
Team tagging indeed seems to work 🎉
openshift-ci
bot
added
the
do-not-merge/work-in-progress
|
Ephemeral COPR build failed. @containers/packit-build please check. |
…ilures This change will auto-tag @containers/packit-build in a github comment on every copr build failure. [NO NEW TESTS NEEDED] Signed-off-by: Lokesh Mandvekar <lsm5@fedoraproject.org>
lsm5
force-pushed
the
packit-fail-tag
branch
from
6594cba
to
6c2493f
Compare
lsm5
changed the title
openshift-ci
bot
removed
the
do-not-merge/work-in-progress
|
LGTM if that team thing works. |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: lsm5, Luap99 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
/cherrypick v4.7 |
|
@lsm5: new pull request created: #20106 In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
github-actions
bot
added
the
locked - please file new issue/PR
Does this PR introduce a user-facing change?