Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adjust machine CPU tests #20101

Merged
merged 2 commits into from Sep 24, 2023
Merged

Adjust machine CPU tests #20101

merged 2 commits into from Sep 24, 2023

Conversation

ashley-cui
Copy link
Member

Machine cpu default has changed to cpus/2, so adjust the tests to reflect that.

Does this PR introduce a user-facing change?

The amount of CPUs a podman machine has now defaults to using  available cores/2. https://github.com/containers/podman/issues/17066

@ashley-cui
Vendor c/common
96142c2 
Signed-off-by: Ashley Cui <acui@redhat.com>
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Sep 22, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ashley-cui

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Sep 22, 2023
@ashley-cui ashley-cui added do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. labels Sep 22, 2023
@ashley-cui ashley-cui mentioned this pull request Sep 22, 2023
Merged
@ashley-cui
Copy link
Member Author

ashley-cui commented Sep 22, 2023 •
edited

Waiting on #20088

TomSweeneyRedHat
TomSweeneyRedHat reviewed Sep 22, 2023
View reviewed changes
Copy link
Member

@TomSweeneyRedHat TomSweeneyRedHat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@vrothberg
Copy link
Member

Not yet happy. LGTM, feel free to merge once green.

@ashley-cui
Adjust machine CPU tests
d8e3057 
Machine cpu default has changed to cpus/2, so adjust the tests to reflect that.

Signed-off-by: Ashley Cui <acui@redhat.com>
@ashley-cui ashley-cui removed do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. labels Sep 22, 2023
@ashley-cui
Copy link
Member Author

ashley-cui commented Sep 22, 2023 •
edited

@containers/podman-maintainers PTAL and merge, this should unblock c/common vendoring :)

@baude
Copy link
Member

baude commented Sep 24, 2023

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Sep 24, 2023
@openshift-merge-robot openshift-merge-robot merged commit 2f7c250 into containers:main Sep 24, 2023
98 checks passed
@ashley-cui ashley-cui deleted the machcpus branch September 28, 2023 22:00
@github-actions github-actions bot added the locked - please file new issue/PR Assist humans wanting to comment on an old issue or PR with locked comments. label Dec 28, 2023
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Dec 28, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@TomSweeneyRedHat TomSweeneyRedHat TomSweeneyRedHat left review comments

Assignees

@baude baude

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. locked - please file new issue/PR Assist humans wanting to comment on an old issue or PR with locked comments. release-note
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@ashley-cui @vrothberg @baude @TomSweeneyRedHat @openshift-merge-robot