New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for annotations #22124
Add support for annotations #22124
Conversation
You need to add a test, but the code change looks good. |
I wrote a test, but also found that |
/retest |
@diplane: Cannot trigger testing until a trusted user reviews the PR and leaves an In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Quay broken. |
One test still failed with same reason |
Done |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you please squash your commits and add a proper commit message because something like Add tests
is not useful for anybody reading the git log.
Your PR description is fine but that is something that should be part of the commit message.
Fix following issues: - create container API handler ignores Annotations from HostConfig - inspect container API handler does not provide Annotations as part of HostConfig Signed-off-by: diplane <diplane3d@gmail.com>
LGTM |
@containers/podman-maintainers PTAL |
/lgtm |
/approve |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: baude, diplane The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
In addition to the issue in docker-compose and the corresponding CL:
docker/compose#11644
docker/compose#11645
Compose doesn't send Annotations as part of the HostConfig to the docker/podman socket.
On the other hand, podman also ignores Annotations received from the create container API handle.
This CL fix that.