-
Notifications
You must be signed in to change notification settings - Fork 2.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add list
as an alias to list networks
#22406
Conversation
list
with an alias of ls
list
as an alias to list networks
Ephemeral COPR build failed. @containers/packit-build please check. |
I don't think this needs tests. 🤷♀️ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes this should have a test, you could just change an existing test from ls
to list
, e.g. in test/system/500-networking.bats
But yes you can ignore the packit failures |
nope :) But I guess that's as green as it gets? |
you need to rebase on main to pick up the CI fixes. But I guess I am comfortable force merging this one as it is clearly unrelated to your changes |
this makes it consistent with other commands, but also makes the example actually work Signed-off-by: Evgeni Golov <evgeni@golov.de>
well, if it's as easy as an rebase, here we go :) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: evgeni, Luap99 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/lgtm |
60e0ef3
into
containers:main
this makes it consistent with other commands (like image and container),
but also makes the example actually work
Signed-off-by: Evgeni Golov evgeni@golov.de
Does this PR introduce a user-facing change?