Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add list as an alias to list networks #22406

Merged
merged 1 commit into from
Apr 17, 2024

Conversation

evgeni
Copy link
Contributor

@evgeni evgeni commented Apr 17, 2024

this makes it consistent with other commands (like image and container),
but also makes the example actually work

Signed-off-by: Evgeni Golov evgeni@golov.de

Does this PR introduce a user-facing change?

None

@evgeni evgeni changed the title list networks using list with an alias of ls add list as an alias to list networks Apr 17, 2024
Copy link

Ephemeral COPR build failed. @containers/packit-build please check.

@evgeni
Copy link
Contributor Author

evgeni commented Apr 17, 2024

I don't think this needs tests.
And I don't think the packit failures are related.

🤷‍♀️

Copy link
Member

@Luap99 Luap99 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes this should have a test, you could just change an existing test from ls to list, e.g. in test/system/500-networking.bats

@Luap99
Copy link
Member

Luap99 commented Apr 17, 2024

But yes you can ignore the packit failures

@evgeni
Copy link
Contributor Author

evgeni commented Apr 17, 2024

Error: initializing source docker://nixery.dev/shell:latest: pinging container registry nixery.dev: received unexpected HTTP status: 502 Bad Gateway

nope :)

But I guess that's as green as it gets?

@Luap99
Copy link
Member

Luap99 commented Apr 17, 2024

Error: initializing source docker://nixery.dev/shell:latest: pinging container registry nixery.dev: received unexpected HTTP status: 502 Bad Gateway

nope :)

But I guess that's as green as it gets?

you need to rebase on main to pick up the CI fixes. But I guess I am comfortable force merging this one as it is clearly unrelated to your changes

this makes it consistent with other commands,
but also makes the example actually work

Signed-off-by: Evgeni Golov <evgeni@golov.de>
@evgeni
Copy link
Contributor Author

evgeni commented Apr 17, 2024

well, if it's as easy as an rebase, here we go :)

Copy link
Member

@Luap99 Luap99 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

openshift-ci bot commented Apr 17, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: evgeni, Luap99

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Apr 17, 2024
@rhatdan
Copy link
Member

rhatdan commented Apr 17, 2024

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Apr 17, 2024
@openshift-merge-bot openshift-merge-bot bot merged commit 60e0ef3 into containers:main Apr 17, 2024
92 of 94 checks passed
@evgeni evgeni deleted the network-list branch April 17, 2024 17:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. release-note-none
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants