Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Vendor in containers/(storage, common) #22469

Closed
wants to merge 1 commit into from
Closed

Conversation

rhatdan
Copy link
Member

@rhatdan rhatdan commented Apr 23, 2024

Does this PR introduce a user-facing change?

None

Signed-off-by: Daniel J Walsh <dwalsh@redhat.com>
Copy link
Contributor

openshift-ci bot commented Apr 23, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: rhatdan

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Apr 23, 2024
@rhatdan
Copy link
Member Author

rhatdan commented Apr 23, 2024

@edsantiago a lot of the fixes for composefs from containers/storage by @giuseppe should be in this PR.

@Luap99
Copy link
Member

Luap99 commented Apr 23, 2024

we need #22465 first to bump go

@edsantiago
Copy link
Collaborator

Please revendor once containers/storage#1904 merges

Copy link

Ephemeral COPR build failed. @containers/packit-build please check.

@edsantiago
Copy link
Collaborator

Also, "thinpool" seems to be gone in latest c-storage, and now podman barfs:

WARN[0000] Failed to decode the keys ["storage.options.thinpool"] from "/usr/share/containers/storage.conf"

Not sure if this needs to be fixed in podman-land or something-else-land.

@edsantiago
Copy link
Collaborator

You'll also need to wait for a fix for containers/storage#1909

@openshift-merge-robot openshift-merge-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Apr 27, 2024
@openshift-merge-robot
Copy link
Collaborator

PR needs rebase.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@vrothberg
Copy link
Member

Not needed after #22638 anymore

@vrothberg vrothberg closed this May 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. release-note-none
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants