Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CI:DOCS] Trigger windows installer action properly #22669

Merged
merged 1 commit into from May 14, 2024

Conversation

ashley-cui
Copy link
Member

Add the needed GH_TOKEN for the windows action.

See: https://github.com/containers/podman/actions/runs/9036143646/job/24832415217#step:17:1

Does this PR introduce a user-facing change?

None

Copy link
Contributor

openshift-ci bot commented May 10, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ashley-cui

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label May 10, 2024
Copy link

Ephemeral COPR build failed. @containers/packit-build please check.

Add the needed GH_TOKEN for the windows action.

Signed-off-by: Ashley Cui <acui@redhat.com>
Copy link
Member

@Luap99 Luap99 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM
However if we now build the artifacts in github action anyway would it make more sense to integrate the actions into one instead of having them depend on each other?

@ashley-cui
Copy link
Member Author

@Luap99 Would be a good idea for the future! Though I know there's a bunch of work going on in the windows build/install side that I don't necessarily want to conflict for now, so I'd argue for merging this and consolidating all the artifact build actions into one later.

@Luap99
Copy link
Member

Luap99 commented May 14, 2024

@Luap99 Would be a good idea for the future! Though I know there's a bunch of work going on in the windows build/install side that I don't necessarily want to conflict for now, so I'd argue for merging this and consolidating all the artifact build actions into one later.

Yes of course, I am not against merging thus my LGTM above.

@mheon
Copy link
Member

mheon commented May 14, 2024

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label May 14, 2024
@openshift-merge-bot openshift-merge-bot bot merged commit d7d4870 into containers:main May 14, 2024
40 of 42 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. release-note-none
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants