Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[v4.9] Unmaintained branch - Disable CI #22840

Closed
wants to merge 1 commit into from

Conversation

cevich
Copy link
Member

@cevich cevich commented May 29, 2024

This branch is no-longer maintained.

Does this PR introduce a user-facing change?

None

@openshift-ci openshift-ci bot added the do-not-merge/release-note-label-needed Enforce release-note requirement, even if just None label May 29, 2024
This branch is no-longer maintained.

Signed-off-by: Chris Evich <cevich@redhat.com>
@openshift-ci openshift-ci bot added release-note-none and removed do-not-merge/release-note-label-needed Enforce release-note requirement, even if just None labels May 29, 2024
@cevich
Copy link
Member Author

cevich commented May 29, 2024

This will need to be merged manually. The Total Success task will never run for this PR.

Copy link

Ephemeral COPR build failed. @containers/packit-build please check.

@edsantiago
Copy link
Collaborator

/approve
/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label May 29, 2024
Copy link
Contributor

openshift-ci bot commented May 29, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: cevich, edsantiago

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label May 29, 2024
@mheon
Copy link
Member

mheon commented May 29, 2024

LGTM

@edsantiago
Copy link
Collaborator

This will need to be merged manually.

The "Merge pull request" button is grayed out in my view. I see "tide - In merge pool" but no actual progress.

Copy link
Member

@Luap99 Luap99 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The reason the merge bot and github merge is blocked because they are configured to block on Total Success and because the task is deleted here it will never pass.

However why are we dropping the v4.9 branch? Didn't we just talked about doing another security release today for fedora 39? What am I missing? #22794

Fedora 39 will be supported for another 5-6 months.

@Luap99
Copy link
Member

Luap99 commented May 30, 2024

/hold

@openshift-ci openshift-ci bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label May 30, 2024
@mheon
Copy link
Member

mheon commented May 30, 2024

I thought we were disabling nightlies... We might want on 100% removal until F39 ages out as Paul said

@openshift-merge-robot openshift-merge-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label May 30, 2024
@openshift-merge-robot
Copy link
Collaborator

PR needs rebase.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@cevich
Copy link
Member Author

cevich commented May 30, 2024

Thanks for putting a hold on this. I'm going to close this PR and re-enable the daily CI-maintenance runs. It seems we need to keep this branch alive until October-ish.

@cevich cevich closed this May 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. lgtm Indicates that a PR is ready to be merged. needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. release-note-none
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants