podman: add new hidden flag --pull-option #22977
Conversation
giuseppe
added
the
No New Tests
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: giuseppe The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-ci
bot
added
the
approved
|
@edsantiago I've added a new flag to override pull options from the CLI. It needs containers/storage#1966 though |
|
Cockpit tests failed for commit b651bae. @martinpitt, @jelly, @mvollmer please check. |
Signed-off-by: Giuseppe Scrivano <gscrivan@redhat.com>
giuseppe
force-pushed
the
add-pull-option-cli
branch
from
b651bae
to
3fb920a
Compare
cmd/podman/root.go
Outdated
| @@ -580,6 +580,8 @@ func rootFlags(cmd *cobra.Command, podmanConfig *entities.PodmanConfig) { | |||
|
|
|||
| pFlags.BoolVar(&podmanConfig.TransientStore, "transient-store", false, "Enable transient container storage") | |||
|
|
|||
| pFlags.StringArrayVar(&podmanConfig.PullOptions, "pull-option", nil, "Tweak how an image is pulled") | |||
There was a problem hiding this comment.
if this can be seen by users, it probably should be something that uses words like "custom pull options" overrides, etc.?
There was a problem hiding this comment.
it is not visible, but better to improve it so it is ready when/if decide to make it visible.
Changed in the new version
|
code LGTM ; would like to see the CLI help tightened up if convenient. |
add a new flag that allows to override the pull options configured in the storage.conf file. e.g.: --pull-option="enable_partial_images=false" can be specified to Podman to disable partial pulls even if enabled. Leave it as a hidden configuration flag for now since the API itself is marked as experimental in c/storage. Currently c/storage doesn't honor the overrides, being fixed with containers/storage#1966 Signed-off-by: Giuseppe Scrivano <gscrivan@redhat.com>
giuseppe
force-pushed
the
add-pull-option-cli
branch
from
3fb920a
to
730a215
Compare
|
/lgtm |
add a new flag that allows to override the pull options configured in the storage.conf file.
e.g.: --pull-option="enable_partial_images=false" can be specified to Podman to disable partial pulls even if enabled.
Leave it as a hidden configuration flag for now since the API itself is marked as experimental in c/storage.
Currently c/storage doesn't honor the overrides, being fixed with containers/storage#1966