Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add flag --extract tar file in podman cp #2532

Merged
merged 1 commit into from
Mar 6, 2019

Conversation

QiWang19
Copy link
Collaborator

@QiWang19 QiWang19 commented Mar 4, 2019

fix #2520
Use --extract to extract tar file in source argument to the destination directory
Signed-off-by: Qi Wang qiwan@redhat.com


**--extract**

Extract the tar file into the destination directory. If the destination argument is not give, extract the tar file in root directory.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

suggest:

"Extract the tar file into the destination directory. If the destination option is not provided, extract the tar file into the root directory."

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

oops, my bad, try

"Extract the tar file into the destination directory. If the destination directory is not provided, extract the tar file into the root directory."

Copy link
Member

@TomSweeneyRedHat TomSweeneyRedHat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

need to add 'extract' to bash completions.

@giuseppe
Copy link
Member

giuseppe commented Mar 5, 2019

LGTM once you address the comments from @TomSweeneyRedHat

@QiWang19
Copy link
Collaborator Author

QiWang19 commented Mar 5, 2019

@giuseppe @TomSweeneyRedHat fixed 🙋‍♀️

@mheon
Copy link
Member

mheon commented Mar 5, 2019

/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Mar 5, 2019
--extract
"
_complete_ "$boolean_options"
}
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice, didn't realize this was entirely missing....

@TomSweeneyRedHat
Copy link
Member

LGTM

@mheon
Copy link
Member

mheon commented Mar 5, 2019

/approve
bot, retest this please

@openshift-ci-robot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: mheon, QiWang19

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci-robot openshift-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Mar 5, 2019
@jlebon
Copy link
Contributor

jlebon commented Mar 5, 2019

bot, retest this please

Signed-off-by: Qi Wang <qiwan@redhat.com>
@openshift-ci-robot openshift-ci-robot removed the lgtm Indicates that a PR is ready to be merged. label Mar 6, 2019
@mheon
Copy link
Member

mheon commented Mar 6, 2019

bot, retest this please
/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Mar 6, 2019
@jlebon
Copy link
Contributor

jlebon commented Mar 6, 2019

bot, retest this please

@openshift-merge-robot openshift-merge-robot merged commit ef71475 into containers:master Mar 6, 2019
@QiWang19 QiWang19 deleted the i2520 branch March 6, 2019 18:10
@github-actions github-actions bot added the locked - please file new issue/PR Assist humans wanting to comment on an old issue or PR with locked comments. label Sep 27, 2023
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Sep 27, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. locked - please file new issue/PR Assist humans wanting to comment on an old issue or PR with locked comments.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

RFE Add --extract option to podman cp commands
7 participants