pod: fix segfault when there are no arguments to inspect #2684
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: giuseppe The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-ci-robot
added
the
approved
Closes: containers#2681 Signed-off-by: Giuseppe Scrivano <gscrivan@redhat.com>
giuseppe
force-pushed
the
fix-crash-pod-inspect
branch
from
3f37280
to
7fee7d8
Compare
|
LGTM |
|
@tobwin PTAL |
| @@ -44,6 +44,11 @@ func podInspectCmd(c *cliconfig.PodInspectValues) error { | |||
| pod *adapter.Pod | |||
There was a problem hiding this comment.
I can't comment up higher, but the message at line 37 says: "Act on the latest container podman is aware of". I think that should be "latest pod podman".
|
/lgtm |
edsantiago
added a commit
to edsantiago/libpod
that referenced
this pull request
Mar 18, 2019
Inspired by containers#2684, I wrote a CI test to look for other such instances in which a command is invoked without a required argument. 'podman umount' seems to be the only one. Signed-off-by: Ed Santiago <santiago@redhat.com>
edsantiago
added a commit
to edsantiago/libpod
that referenced
this pull request
Mar 18, 2019
Inspired by containers#2684, I wrote a CI test to look for other such instances in which a command is invoked without a required argument. 'podman umount' seems to be the only one. Signed-off-by: Ed Santiago <santiago@redhat.com>
edsantiago
added a commit
to edsantiago/libpod
that referenced
this pull request
Mar 18, 2019
Inspired by containers#2684, I wrote a CI test to look for other such instances in which a command is invoked without a required argument. 'podman umount' seems to be the only one; but 'podman mount' also needs a change, to indicate that its CONTAINER argument is optional. Signed-off-by: Ed Santiago <santiago@redhat.com>
edsantiago
added a commit
to edsantiago/libpod
that referenced
this pull request
Mar 18, 2019
Inspired by containers#2684, I wrote a CI test to look for other such instances in which a command is invoked without a required argument. 'podman umount' seems to be the only one, and solution is simple: checkAllAndLatest() already does the check for us. Resolve a few other problems uncovered by testing: podman mount: indicate that CONTAINER arg is optional podman pod stats: ditto podman generate kube: remove check for -l (latest) flag, it isn't actually implemented. Signed-off-by: Ed Santiago <santiago@redhat.com>
muayyad-alsadi
pushed a commit
to muayyad-alsadi/libpod
that referenced
this pull request
Apr 21, 2019
Inspired by containers#2684, I wrote a CI test to look for other such instances in which a command is invoked without a required argument. 'podman umount' seems to be the only one, and solution is simple: checkAllAndLatest() already does the check for us. Resolve a few other problems uncovered by testing: podman mount: indicate that CONTAINER arg is optional podman pod stats: ditto podman generate kube: remove check for -l (latest) flag, it isn't actually implemented. Signed-off-by: Ed Santiago <santiago@redhat.com>
github-actions
bot
added
the
locked - please file new issue/PR
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes: #2681
Signed-off-by: Giuseppe Scrivano gscrivan@redhat.com