support GO template {{ json . }} #2688
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: baude The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-ci-robot
added
approved
rhatdan
reviewed
Mar 18, 2019
for podman version, we now support a GO template for json output. fixes containers#2671 Signed-off-by: baude <bbaude@redhat.com>
|
LGTM |
mheon
reviewed
Mar 18, 2019
| Expect(session.IsJSONOutputValid()).To(BeTrue()) | ||
| }) | ||
|
|
||
| It("podman version --format json", func() { |
There was a problem hiding this comment.
Change the name - we have two tests with the same name
|
LGTM |
|
/lgtm |
This was referenced Oct 31, 2019
Closed
github-actions
bot
added
the
locked - please file new issue/PR
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
for podman version, we now support a GO template for json output.
fixes #2671
Signed-off-by: baude bbaude@redhat.com