Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add some global options to build #312

Closed
wants to merge 1 commit into from
Closed

Add some global options to build #312

wants to merge 1 commit into from

Conversation

TomSweeneyRedHat
Copy link
Member

Signed-off-by: TomSweeneyRedHat tsweeney@redhat.com

Add some but not all of the Podman global options to the build command. Need to work out more. These are the ones that are common with Buildah. Adds debug logging, root, runroot, storage-driver and storage-opt.

I'll add more in another PR, wanted to get these up as I know folks have been looking for the debug logging.

Signed-off-by: TomSweeneyRedHat <tsweeney@redhat.com>
@TomSweeneyRedHat
Copy link
Member Author

@ipbabble fyi

@ipbabble
Copy link
Collaborator

ipbabble commented Feb 8, 2018

I like that --debug propagation . LGTM

@TomSweeneyRedHat
Copy link
Member Author

bot, retest this please

1 similar comment
@TomSweeneyRedHat
Copy link
Member Author

bot, retest this please

@TomSweeneyRedHat
Copy link
Member Author

@mheon smoketested keeps failing w/o logs/errors. Known issue?

@mheon
Copy link
Member

mheon commented Feb 8, 2018

@TomSweeneyRedHat It looks like the Cent VMs on Papr are having issues coming up. Not sure why. Probably related to homu not working at all the last few days.

@mheon
Copy link
Member

mheon commented Feb 8, 2018

bot, retest this please

@TomSweeneyRedHat
Copy link
Member Author

Finally all green for problem child number 2

@mheon
Copy link
Member

mheon commented Feb 8, 2018

LGTM

@mheon
Copy link
Member

mheon commented Feb 8, 2018

I'm going to try rh-atomic-bot and see if it's recovered

@mheon
Copy link
Member

mheon commented Feb 8, 2018

@rh-atomic-bot r+

@rh-atomic-bot
Copy link
Collaborator

📌 Commit def7a4e has been approved by mheon

@rh-atomic-bot
Copy link
Collaborator

⌛ Testing commit def7a4e with merge 9e3a5da...

@rh-atomic-bot
Copy link
Collaborator

☀️ Test successful - status-papr
Approved by: mheon
Pushing 9e3a5da to master...

@TomSweeneyRedHat TomSweeneyRedHat deleted the dev/tsweeney/globalflags branch February 8, 2018 20:47
baude pushed a commit to baude/podman that referenced this pull request Aug 31, 2019
@github-actions github-actions bot added the locked - please file new issue/PR Assist humans wanting to comment on an old issue or PR with locked comments. label Sep 27, 2023
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Sep 27, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
locked - please file new issue/PR Assist humans wanting to comment on an old issue or PR with locked comments.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants