Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Begin to break up pkg/inspect #3180

Merged
merged 1 commit into from
Jun 8, 2019
Merged

Begin to break up pkg/inspect #3180

merged 1 commit into from
Jun 8, 2019

Conversation

mheon
Copy link
Member

@mheon mheon commented May 21, 2019

Let's put inspect structs where they're actually being used. We originally made pkg/inspect to solve circular import issues. There are no more circular import issues.

Image structs remain for now, I'm focusing on container inspect.

This is Phase 1 of a more comprehensive rework of Inspect, to try and fill in missing fields and make sure what we are printing is sane and consistent with docker inspect

@openshift-ci-robot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: mheon

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci-robot openshift-ci-robot added approved Indicates a PR has been approved by an approver from all required OWNERS files. size/XL labels May 21, 2019
@mheon mheon force-pushed the inspect_volumes branch 3 times, most recently from fc20b88 to 73b11c5 Compare May 23, 2019 03:44
@mheon mheon mentioned this pull request May 23, 2019
Closed
@mheon mheon force-pushed the inspect_volumes branch 2 times, most recently from 7d23f4b to 629a1dd Compare May 23, 2019 18:31
@mheon mheon mentioned this pull request May 29, 2019
Closed
@mheon
Copy link
Member Author

mheon commented May 29, 2019

Remarking for 1.5.0, let's not make gigantic breaking changes in 1.4.0

@mheon
Copy link
Member Author

mheon commented May 29, 2019

Well, this isn't breaking, but it moves a lot of code around, so we could have broken something

@rh-atomic-bot
Copy link
Collaborator

☔ The latest upstream changes (presumably #2709) made this pull request unmergeable. Please resolve the merge conflicts.

@openshift-ci-robot openshift-ci-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label May 29, 2019
@mheon
Copy link
Member Author

mheon commented Jun 3, 2019

Alright, let's just get this one in, it's lingering too long. Retagging for 1.4.0 and rebasing.

@mheon
Begin to break up pkg/inspect
1be345b 
Let's put inspect structs where they're actually being used. We
originally made pkg/inspect to solve circular import issues.
There are no more circular import issues.

Image structs remain for now, I'm focusing on container inspect.

Signed-off-by: Matthew Heon <matthew.heon@pm.me>
@openshift-ci-robot openshift-ci-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Jun 3, 2019
@mheon
Copy link
Member Author

mheon commented Jun 4, 2019

Note to self: image IDs are printed in docker inspect with a sha256: prefix that we do not duplicate.

@mheon
Copy link
Member Author

mheon commented Jun 5, 2019

Alright, CI is green. @rhatdan @haircommander @baude @TomSweeneyRedHat @vrothberg @giuseppe PTAL

@rhatdan
Copy link
Member

rhatdan commented Jun 5, 2019

LGTM

@rhatdan
Copy link
Member

rhatdan commented Jun 8, 2019

@haircommander @baude @TomSweeneyRedHat @vrothberg @giuseppe PTAL
Can we get this in?

@haircommander
Copy link
Collaborator

/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Jun 8, 2019
@openshift-merge-robot openshift-merge-robot merged commit 39f5ea4 into containers:master Jun 8, 2019
This was referenced Jun 8, 2019
Merged
Merged
@github-actions github-actions bot added the locked - please file new issue/PR Assist humans wanting to comment on an old issue or PR with locked comments. label Sep 26, 2023
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Sep 26, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@giuseppe giuseppe Awaiting requested review from giuseppe

@TomSweeneyRedHat TomSweeneyRedHat Awaiting requested review from TomSweeneyRedHat

Assignees

@haircommander haircommander

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. locked - please file new issue/PR Assist humans wanting to comment on an old issue or PR with locked comments.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@mheon @openshift-ci-robot @rh-atomic-bot @rhatdan @haircommander @openshift-merge-robot