Honor ENTRYPOINT in image #322
Conversation
| } | ||
| if len(inputCommand) > 0 { | ||
| // User command overrides data CMD | ||
| command = append(command, inputCommand...) |
There was a problem hiding this comment.
Is this right? I thought user command overrode ENTRYPOINT as well?
There was a problem hiding this comment.
It's correct.
2018-02-10 13:22:22 ⌚ localhost in ~/tmp/entrypoint
○ → cat Dockerfile
FROM alpine
ENTRYPOINT ["ls"]
2018-02-10 13:22:31 ⌚ localhost in ~/tmp/entrypoint
○ → docker run -it --rm entrycmd:latest top
ls: top: No such file or directory
|
One question, otherwise LGTM |
|
|
||
| // BuildImage uses podman build and buildah to build an image | ||
| // called imageName based on a string dockerfile | ||
| func (p *PodmanTest) BuildImage(dockerfile, imageName string) { |
There was a problem hiding this comment.
fingers crossed that this will work, but ipbabble's been having some fun getting Buildah to run in a Docker container.
|
Looks like Travis is failing due to not being able to find go-md2man. Do you need to install that in the container too? Do you have the other Buildah pre-reqs covered? |
When an image has an ENTRYPOINT defined, we should be honoring it. The problem is described in issue containers#321. Also, added buildah binary to test runtimes for testing entrypoint and will also allow us to test podman build as well. Signed-off-by: baude <bbaude@redhat.com>
|
bot, retest this please |
|
Papr tests don't seem to be triggering, manually triggering to see if they run |
|
Nice work @baude, I really didn't expect green buttons due to the tests. LGTM |
|
bot, retest this please |
|
Papr still appears broken |
|
📌 Commit 8582466 has been approved by |
|
@ipbabble Please try your buildah tests with this new entrypoint code. |
|
☀️ Test successful - status-papr |
Update github.com/safchain/ethtool to fix the compilation error on 386. Also added 386 to the tarvis yaml. Fixes containers#322 Signed-off-by: Moshe Levi <moshele@mellanox.com>
github-actions
bot
added
the
locked - please file new issue/PR
When an image has an ENTRYPOINT defined, we should be honoring it. The
problem is described in issue #321.
Also, added buildah binary to test runtimes for testing entrypoint and
will also allow us to test podman build as well.
Signed-off-by: baude bbaude@redhat.com