Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix bug creats directory copying file #3391

Merged
merged 1 commit into from Jun 24, 2019

Conversation

QiWang19
Copy link
Collaborator

close #3384

Signed-off-by: Qi Wang qiwan@redhat.com

close containers#3384

Signed-off-by: Qi Wang <qiwan@redhat.com>
@rhatdan
Copy link
Member

rhatdan commented Jun 21, 2019

/approve
@QiWang19 Can you add some tests for this?

@openshift-ci-robot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: QiWang19, rhatdan

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci-robot openshift-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jun 21, 2019
@QiWang19
Copy link
Collaborator Author

I have made changes in the tests to cat the file.

@rhatdan
Copy link
Member

rhatdan commented Jun 21, 2019

I don't see a Cat of a file?

@QiWang19
Copy link
Collaborator Author

I start the container has cat foo command

@QiWang19
Copy link
Collaborator Author

can this get in? Do I need to add more tests for the changes?
@mheon @TomSweeneyRedHat

@rhatdan
Copy link
Member

rhatdan commented Jun 24, 2019

LGTM

@mheon
Copy link
Member

mheon commented Jun 24, 2019

/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Jun 24, 2019
@openshift-merge-robot openshift-merge-robot merged commit 394e12a into containers:master Jun 24, 2019
@QiWang19 QiWang19 deleted the cp_file branch June 26, 2020 15:11
@github-actions github-actions bot added the locked - please file new issue/PR Assist humans wanting to comment on an old issue or PR with locked comments. label Sep 24, 2023
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Sep 24, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. locked - please file new issue/PR Assist humans wanting to comment on an old issue or PR with locked comments.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Podman creates directory when copying a file from and to container
5 participants