Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Cirrus: Execute system-tests during image-validation #3534

Merged
merged 3 commits into from
Jul 12, 2019
Merged

Cirrus: Execute system-tests during image-validation #3534

merged 3 commits into from
Jul 12, 2019

Conversation

cevich
Copy link
Member

@cevich cevich commented Jul 9, 2019 •
edited

Signed-off-by: Chris Evich cevich@redhat.com

@cevich
Copy link
Member Author

cevich commented Jul 9, 2019

/hold

@openshift-ci-robot openshift-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jul 9, 2019
@edsantiago
Copy link
Collaborator

CI failure seems to be a combination of #3193 and #1936 ; in particular, this line in check_image.sh:

item_test "podman command NOT found on path" -z "$(type -P podman)" || let "RET+=1"

...combined with the addition of dnf install podman to contrib/cirrus/packer/fedora_setup.sh in #1936. There is no comment in check_image.sh explaining why that test is important; and no comment in #1936 explaining why podman was added. And no explanation of how this passed CI. I'm trying to investigate and understand but am getting nowhere.

@rhatdan
Copy link
Member

rhatdan commented Jul 9, 2019

LGTM

@cevich
Copy link
Member Author

cevich commented Jul 9, 2019

/hold cancel

@openshift-ci-robot openshift-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jul 9, 2019
@cevich
Copy link
Member Author

cevich commented Jul 9, 2019

Note: Stepping away from this PR for now, since it's disproven a hypothesis that old packages were causing system-test flake. Will come back here once that problem is sorted via other means.

@cevich
Copy link
Member Author

cevich commented Jul 9, 2019

Note: This needs rebasing on #3536 to pass system-tests.

@mheon
Copy link
Member

mheon commented Jul 10, 2019

/approve

@openshift-ci-robot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: cevich, mheon

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci-robot openshift-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jul 10, 2019
@mheon mheon mentioned this pull request Jul 10, 2019
Merged
@cevich cevich mentioned this pull request Jul 10, 2019
Merged
@cevich cevich mentioned this pull request Jul 11, 2019
Closed
@rhatdan
Copy link
Member

rhatdan commented Jul 11, 2019

/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Jul 11, 2019
@edsantiago
Copy link
Collaborator

/lgtm

@mheon
Copy link
Member

mheon commented Jul 11, 2019

/hold

@openshift-ci-robot openshift-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jul 11, 2019
@openshift-ci-robot openshift-ci-robot removed the lgtm Indicates that a PR is ready to be merged. label Jul 11, 2019
@cevich
Cirrus: Fix missing removal of packaged podman
9043b81 
This was originally intended, but somehow omitted from containers#1936

Signed-off-by: Chris Evich <cevich@redhat.com>
@cevich
Cirrus: Execute system-tests during image-validation
6946fe0 
Signed-off-by: Chris Evich <cevich@redhat.com>
@cevich
Cirrus: Update to freshly built cache-images
dc385fc 
Signed-off-by: Chris Evich <cevich@redhat.com>
@mheon
Copy link
Member

mheon commented Jul 12, 2019

/lgtm
/hold cancel

@openshift-ci-robot openshift-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jul 12, 2019
@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Jul 12, 2019
@openshift-merge-robot openshift-merge-robot merged commit 686da0d into containers:master Jul 12, 2019
@cevich cevich deleted the img_sys_tst branch June 30, 2021 18:11
@github-actions github-actions bot added the locked - please file new issue/PR Assist humans wanting to comment on an old issue or PR with locked comments. label Sep 22, 2023
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Sep 22, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@edsantiago edsantiago edsantiago left review comments

@mrunalp mrunalp Awaiting requested review from mrunalp

@rhatdan rhatdan Awaiting requested review from rhatdan

Assignees

@edsantiago edsantiago

@rhatdan rhatdan

@mheon mheon

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. locked - please file new issue/PR Assist humans wanting to comment on an old issue or PR with locked comments.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@cevich @edsantiago @rhatdan @mheon @openshift-ci-robot @openshift-merge-robot