Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Revert "libpod, rootless: create cgroup for conmon" #4835

Closed
wants to merge 1 commit into from
Closed

Revert "libpod, rootless: create cgroup for conmon" #4835

wants to merge 1 commit into from

Conversation

vrothberg
Copy link
Member

This reverts commit 78e2a31.

Fixes: #4833
Signed-off-by: Valentin Rothberg rothberg@redhat.com

@giuseppe PTAL

@vrothberg
Revert "libpod, rootless: create cgroup for conmon"
839ac19 
This reverts commit 78e2a31.

Fixes: containers#4833
Signed-off-by: Valentin Rothberg <rothberg@redhat.com>
@openshift-ci-robot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: vrothberg

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci-robot openshift-ci-robot added approved Indicates a PR has been approved by an approver from all required OWNERS files. size/XS labels Jan 10, 2020
@vrothberg vrothberg mentioned this pull request Jan 10, 2020
Closed
@vrothberg
Copy link
Member Author

@edsantiago, I'd love to have some (system?) tests that run simple containers in systemd service (root & rootless). Do you think that's possible or are there some potential issues I might not have thought of?

@giuseppe
Copy link
Member

root containers also create the cgroup for conmon? Is the difference the fact we leave two processes running in the cgroup (slirp4netns and fuse-overlayfs)?

@giuseppe
Copy link
Member

reverting the patch will break running rootless containers from within a cgroup not owned by the rootless user, e.g. a session created by another user such as root

@vrothberg
Copy link
Member Author

reverting the patch will break running rootless containers from within a cgroup not owned by the rootless user, e.g. a session created by another user such as root

Good point. I'll close the PR.

Is the difference the fact we leave two processes running in the cgroup (slirp4netns and fuse-overlayfs)?

Systemd doesn't like that apparently

@vrothberg vrothberg closed this Jan 10, 2020
@vrothberg vrothberg deleted the systemd branch January 10, 2020 17:27
@github-actions github-actions bot added the locked - please file new issue/PR Assist humans wanting to comment on an old issue or PR with locked comments. label Sep 25, 2023
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Sep 25, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@giuseppe giuseppe Awaiting requested review from giuseppe

@umohnani8 umohnani8 Awaiting requested review from umohnani8

Assignees
No one assigned
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. locked - please file new issue/PR Assist humans wanting to comment on an old issue or PR with locked comments.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

rootless container - systemd user service fails on 1.7.0 but is working on 1.6.2
3 participants
@vrothberg @openshift-ci-robot @giuseppe