clarify cont #4845
Merged
clarify cont #4845
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: baude The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-ci-robot
added
approved
|
LGTM. This is definitely more correct than what we were doing before. |
|
I restarted the cgroupv2 tests, but I think they're going to fail again - seems like something in BeforeSuite is consistently breaking |
vrothberg
reviewed
Jan 13, 2020
giuseppe
reviewed
Jan 13, 2020
|
LGTM once the commit message is fixed. |
the --force parameter should only be used for the CLI and should only dictate whether to prompt the user for confirmation. Fixes: containers#4844 Signed-off-by: baude <bbaude@redhat.com>
|
/lgtm |
1 similar comment
|
/lgtm |
|
Bot seems broken, manually adding label |
github-actions
bot
added
the
locked - please file new issue/PR
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ainer prune --force
the --force parameter should only be used for the CLI and should only
dictate whether to prompt the user for confirmation.
Fixes: #4844
Signed-off-by: baude bbaude@redhat.com