Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Attempt to turn on additional build tests #6341

Merged
merged 2 commits into from May 22, 2020
Merged

Attempt to turn on additional build tests #6341

merged 2 commits into from May 22, 2020

Conversation

rhatdan
Copy link
Member

@rhatdan rhatdan commented May 22, 2020

Signed-off-by: Daniel J Walsh dwalsh@redhat.com

@openshift-ci-robot openshift-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label May 22, 2020
@rhatdan rhatdan force-pushed the build6 branch 7 times, most recently from 8e170da to 1050fed Compare May 22, 2020 14:43
@rhatdan rhatdan mentioned this pull request May 22, 2020
Closed
@rhatdan rhatdan force-pushed the build6 branch 2 times, most recently from 9add8ba to e7d55df Compare May 22, 2020 14:53
@rhatdan
Copy link
Member Author

rhatdan commented May 22, 2020

Replaces #6340

@rhatdan rhatdan mentioned this pull request May 22, 2020
Closed
@mheon
Copy link
Member

mheon commented May 22, 2020

LGTM, but some tests are red

jwhonce
jwhonce approved these changes May 22, 2020
View reviewed changes
Copy link
Member

@jwhonce jwhonce left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, but there is a build tag issue with aliasTimeoutFlag()

@openshift-ci-robot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jwhonce, rhatdan

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

TomSweeneyRedHat
TomSweeneyRedHat reviewed May 22, 2020
View reviewed changes
pkg/domain/infra/abi/system_varlink.go
if err = service.Listen(opts.URI, opts.Timeout); err != nil {
switch err.(type) {
case varlink.ServiceTimeoutError:
logrus.Infof("varlink service expired (use --timeout to increase session time beyond %s ms, 0 means never timeout)", opts.Timeout.String())
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

is it timeout or time here now?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I will do a separate PR>

TomSweeneyRedHat
TomSweeneyRedHat reviewed May 22, 2020
View reviewed changes
docs/source/markdown/podman-image.1.md
@@ -14,6 +14,7 @@ The image command allows you to manage images
| Command | Man Page | Description |
| -------- | ----------------------------------------------- | --------------------------------------------------------------------------- |
| build | [podman-build(1)](podman-build.1.md) | Build a container using a Dockerfile. |
| diff | [podman-image-diff(1)](podman-image-diff.1.md) | Inspect changes on an image's filesystem. |
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

need this change in commands-demo.md too

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I will do this in a different PR. I want to get this in, so Matt can do a release.

@TomSweeneyRedHat
Copy link
Member

Just curious as to why we're hiding signature-policy?

@mheon
Copy link
Member

mheon commented May 22, 2020

LGTM

@rh-atomic-bot
Copy link
Collaborator

☔ The latest upstream changes (presumably #6332) made this pull request unmergeable. Please resolve the merge conflicts.

@rhatdan
Attempt to turn on additional build tests
35567e7 
Signed-off-by: Daniel J Walsh <dwalsh@redhat.com>
@rhatdan
Attempt to turn on build_without_cgo tests
e410892 
Signed-off-by: Daniel J Walsh <dwalsh@redhat.com>
@TomSweeneyRedHat
Copy link
Member

LGTM

@TomSweeneyRedHat
Copy link
Member

/lgtm
/hold

@jwhonce
Copy link
Member

jwhonce commented May 22, 2020

/lgtm

@openshift-ci-robot openshift-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label May 22, 2020
@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label May 22, 2020
@QiWang19
Copy link
Collaborator

success Cancelled after 18m — Task Summary Does this need rebase to rerun?

@mheon
Copy link
Member

mheon commented May 22, 2020

/hold cancel

@openshift-ci-robot openshift-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label May 22, 2020
@mheon
Copy link
Member

mheon commented May 22, 2020

Damn nice job @rhatdan - that's almost all of our CI reenabled.

@openshift-merge-robot openshift-merge-robot merged commit 4bc8193 into containers:master May 22, 2020
This was referenced May 22, 2020
Merged
Merged
rhatdan added a commit to rhatdan/podman that referenced this pull request May 22, 2020
@rhatdan
Follow up PR to fix issues found in containers#6341
b942546 
Signed-off-by: Daniel J Walsh <dwalsh@redhat.com>
openshift-merge-robot added a commit that referenced this pull request May 23, 2020
@openshift-merge-robot
Merge pull request #6357 from rhatdan/build6
c166b21 
Follow up PR to fix issues found in #6341
snj33v pushed a commit to snj33v/libpod that referenced this pull request May 31, 2020
@rhatdan @snj33v
Follow up PR to fix issues found in containers#6341
39a378d 
Signed-off-by: Daniel J Walsh <dwalsh@redhat.com>
@github-actions github-actions bot added the locked - please file new issue/PR Assist humans wanting to comment on an old issue or PR with locked comments. label Sep 25, 2023
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Sep 25, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@TomSweeneyRedHat TomSweeneyRedHat TomSweeneyRedHat left review comments

@jwhonce jwhonce jwhonce approved these changes

@mrunalp mrunalp Awaiting requested review from mrunalp

Assignees

@jwhonce jwhonce

@TomSweeneyRedHat TomSweeneyRedHat

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. locked - please file new issue/PR Assist humans wanting to comment on an old issue or PR with locked comments.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
8 participants
@rhatdan @mheon @openshift-ci-robot @TomSweeneyRedHat @rh-atomic-bot @jwhonce @QiWang19 @openshift-merge-robot