Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

rootless: system service joins immediately the namespaces #7192

Merged
merged 1 commit into from
Aug 4, 2020
Merged

rootless: system service joins immediately the namespaces #7192

merged 1 commit into from
Aug 4, 2020

Conversation

giuseppe
Copy link
Member

@giuseppe giuseppe commented Aug 3, 2020

when there is a pause process running, let the "system service" podman
instance join immediately the existing namespaces.

Closes: #7180
Closes: #6660

Signed-off-by: Giuseppe Scrivano gscrivan@redhat.com

@openshift-ci-robot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: giuseppe

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci-robot openshift-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Aug 3, 2020
This was referenced Aug 3, 2020
Closed
Closed
@martinpitt
Copy link
Contributor

@giuseppe: I'm happy to test this -- do the CI processes spit out RPMs or debs somewhere which I can use?

@giuseppe
Copy link
Member Author

giuseppe commented Aug 3, 2020

@vrothberg do you know if we generate a RPM automatically?

@martinpitt if it would work for you, I can provide a static binary

@martinpitt
Copy link
Contributor

@giuseppe : Yes, an x86_64 binary is just fine. I do all tests in temporary VMs anyway, so I can mess them up however much I like :)

@giuseppe
Copy link
Member Author

giuseppe commented Aug 3, 2020

@martinpitt uploaded here: podman.gz

@martinpitt
Copy link
Contributor

I confirm that with this binary, the podman pause process still persists, the zombie still exists, but the API now continues to work after podman.service timed out. It gets restarted correctly. Thank you!

👍

vrothberg
vrothberg reviewed Aug 3, 2020
View reviewed changes
Copy link
Member

@vrothberg vrothberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, restarted the flaked test (infra hiccup)

@vrothberg
Copy link
Member

/lgtm
/hold

@openshift-ci-robot openshift-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Aug 3, 2020
@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Aug 3, 2020
@giuseppe
Copy link
Member Author

giuseppe commented Aug 3, 2020

/retest

@giuseppe
rootless: system service joins immediately the namespaces
8df7ab2 
when there is a pause process running, let the "system service" podman
instance join immediately the existing namespaces.

Closes: containers#7180
Closes: containers#6660

Signed-off-by: Giuseppe Scrivano <gscrivan@redhat.com>
@giuseppe giuseppe force-pushed the system-service-join-ns-immediately branch from af2ae9b to 8df7ab2 Compare August 3, 2020 20:08
@openshift-ci-robot openshift-ci-robot removed the lgtm Indicates that a PR is ready to be merged. label Aug 3, 2020
@giuseppe
Copy link
Member Author

giuseppe commented Aug 4, 2020

@vrothberg can I get the lgtm back? :-)

vrothberg
vrothberg reviewed Aug 4, 2020
View reviewed changes
Copy link
Member

@vrothberg vrothberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Aug 4, 2020
@vrothberg
Copy link
Member

:)

@rhatdan
Copy link
Member

rhatdan commented Aug 4, 2020

/hold cancel

@openshift-ci-robot openshift-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Aug 4, 2020
@openshift-merge-robot openshift-merge-robot merged commit 861702e into containers:master Aug 4, 2020
@rptaylor rptaylor mentioned this pull request Sep 14, 2021
Closed
@github-actions github-actions bot added the locked - please file new issue/PR Assist humans wanting to comment on an old issue or PR with locked comments. label Sep 24, 2023
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Sep 24, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@vrothberg vrothberg vrothberg left review comments

@baude baude Awaiting requested review from baude

@mheon mheon Awaiting requested review from mheon

Assignees

@vrothberg vrothberg

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. locked - please file new issue/PR Assist humans wanting to comment on an old issue or PR with locked comments.
Projects
None yet
Milestone
No milestone
6 participants
@giuseppe @openshift-ci-robot @martinpitt @vrothberg @rhatdan @openshift-merge-robot