handle play kube with pod.spec.hostAliases #7496
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zhangguanzhang
force-pushed
the
play-kube-handle-hostAliases
branch
4 times, most recently
from
f2ddfb6
to
47e49db
Compare
|
😢Some errors are in ci, I will fix them when I have time |
zhangguanzhang
force-pushed
the
play-kube-handle-hostAliases
branch
2 times, most recently
from
c8d034b
to
9178f23
Compare
|
LGTM, but I'd like @haircommander to do a review before we merge. |
|
LGTM, though you've got a merge conflict |
|
I will resolve this soon |
Signed-off-by: zhangguanzhang <zhangguanzhang@qq.com>
zhangguanzhang
force-pushed
the
play-kube-handle-hostAliases
branch
from
0b34d23
to
9ec8a60
Compare
|
LGTM |
|
/lgtm (could use an approval) |
|
/approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: mheon, zhangguanzhang The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-ci-robot
added
the
approved
github-actions
bot
added
the
locked - please file new issue/PR
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: #7442
Signed-off-by: zhangguanzhang zhangguanzhang@qq.com