Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix missing completion in podman run #7669

Merged
merged 1 commit into from Sep 17, 2020
Merged

fix missing completion in podman run #7669

merged 1 commit into from Sep 17, 2020

Conversation

zhangguanzhang
Copy link
Collaborator

Fixes: #7668
Signed-off-by: zhangguanzhang zhangguanzhang@qq.com

@rhatdan
Copy link
Member

rhatdan commented Sep 17, 2020

LGTM

@zhangguanzhang
fix missing completion in podman run
e18e4f4 
Signed-off-by: zhangguanzhang <zhangguanzhang@qq.com>
@rhatdan
Copy link
Member

rhatdan commented Sep 17, 2020

/approve

@openshift-ci-robot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: rhatdan, zhangguanzhang

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci-robot openshift-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Sep 17, 2020
@rhatdan
Copy link
Member

rhatdan commented Sep 17, 2020

@TomSweeneyRedHat @mheon @giuseppe @vrothberg @jwhonce @baude @ashley-cui @QiWang19 PTAL

ashley-cui
ashley-cui reviewed Sep 17, 2020
View reviewed changes
Copy link
Member

@ashley-cui ashley-cui left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jwhonce
Copy link
Member

jwhonce commented Sep 17, 2020 •
edited

/hold
/lgtm

Pending tests success

@openshift-ci-robot openshift-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Sep 17, 2020
@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Sep 17, 2020
@TomSweeneyRedHat
Copy link
Member

LGTM
some of the tests are looking reddish....

@jwhonce
Copy link
Member

jwhonce commented Sep 17, 2020

/hold cancel

@openshift-ci-robot openshift-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Sep 17, 2020
@openshift-merge-robot openshift-merge-robot merged commit cedbb05 into containers:master Sep 17, 2020
@zhangguanzhang zhangguanzhang deleted the missing-completion branch September 23, 2020 05:28
@github-actions github-actions bot added the locked - please file new issue/PR Assist humans wanting to comment on an old issue or PR with locked comments. label Sep 24, 2023
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Sep 24, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@ashley-cui ashley-cui ashley-cui left review comments

@jwhonce jwhonce Awaiting requested review from jwhonce

Assignees

@jwhonce jwhonce

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. locked - please file new issue/PR Assist humans wanting to comment on an old issue or PR with locked comments.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

missing completion
7 participants
@zhangguanzhang @rhatdan @openshift-ci-robot @jwhonce @TomSweeneyRedHat @ashley-cui @openshift-merge-robot