Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[apiv2] don't ignore the ENV and WorkDir from the image #7851

Merged
merged 1 commit into from Oct 1, 2020
Merged

[apiv2] don't ignore the ENV and WorkDir from the image #7851

merged 1 commit into from Oct 1, 2020

Conversation

zhangguanzhang
Copy link
Collaborator

Fixes: #7235 (comment)
Signed-off-by: zhangguanzhang zhangguanzhang@qq.com

@zhangguanzhang zhangguanzhang force-pushed the fix-apiv2-ctr-workdir-and-env branch 2 times, most recently from 58e3bb9 to c0b2dae Compare September 30, 2020 17:01
@rhatdan
Copy link
Member

rhatdan commented Sep 30, 2020

LGTM

@edsantiago
Copy link
Collaborator

CI flake is #7139, restarted

edsantiago
edsantiago requested changes Sep 30, 2020
View reviewed changes
Copy link
Collaborator

@edsantiago edsantiago left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you include a descriptive commit message? A future maintainer may not completely understand what problem this commit addresses.

@zhangguanzhang
Copy link
Collaborator Author

Could you include a descriptive commit message? A future maintainer may not completely understand what problem this commit addresses.

done

@edsantiago
Copy link
Collaborator

Hmmm, can you double-check? I'm still not seeing a commit message. What do you see when you click the Commits tab and then click the ... expander?

@zhangguanzhang
fix: The container created by APIV2 has an incorrect Env and WorkDir
cde367c 
Signed-off-by: zhangguanzhang <zhangguanzhang@qq.com>
@zhangguanzhang
Copy link
Collaborator Author

Hmmm, can you double-check? I'm still not seeing a commit message. What do you see when you click the Commits tab and then click the ... expander?

My mistake, the edit was wrong when rebase 😥

@rhatdan
Copy link
Member

rhatdan commented Oct 1, 2020

/approve

@openshift-ci-robot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: rhatdan, zhangguanzhang

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci-robot openshift-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Oct 1, 2020
@zhangguanzhang zhangguanzhang requested review from mheon and removed request for jwhonce October 1, 2020 10:48
@mheon
Copy link
Member

mheon commented Oct 1, 2020

/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Oct 1, 2020
@openshift-merge-robot openshift-merge-robot merged commit 3948cb7 into containers:master Oct 1, 2020
@rhatdan
Copy link
Member

rhatdan commented Oct 1, 2020

Thanks @zhangguanzhang

@zhangguanzhang zhangguanzhang deleted the fix-apiv2-ctr-workdir-and-env branch November 18, 2020 09:32
@github-actions github-actions bot added the locked - please file new issue/PR Assist humans wanting to comment on an old issue or PR with locked comments. label Sep 24, 2023
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Sep 24, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@edsantiago edsantiago edsantiago requested changes

@rhatdan rhatdan Awaiting requested review from rhatdan

@mheon mheon Awaiting requested review from mheon

Assignees

@mheon mheon

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. locked - please file new issue/PR Assist humans wanting to comment on an old issue or PR with locked comments.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[APIv2] Create container does not initialize WorkingDir and few other things
6 participants
@zhangguanzhang @rhatdan @edsantiago @openshift-ci-robot @mheon @openshift-merge-robot