Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[apiv2] /containers/$name/json return wrong value in .Config.StopSignal #7918

Merged
merged 1 commit into from Oct 6, 2020
Merged

[apiv2] /containers/$name/json return wrong value in .Config.StopSignal #7918

merged 1 commit into from Oct 6, 2020

Conversation

zhangguanzhang
Copy link
Collaborator

Fixes: #7917

Signed-off-by: zhangguanzhang zhangguanzhang@qq.com

@edsantiago
Copy link
Collaborator

Nice catch.

@zhangguanzhang
Copy link
Collaborator Author

Nice catch.

ci errored ....

@zhangguanzhang zhangguanzhang changed the title fix apiv2 /containers/$name/json return wrong value in .Config.StopSignal [apiv2] /containers/$name/json return wrong value in .Config.StopSignal Oct 5, 2020
@edsantiago
Copy link
Collaborator

unable to pull quay.io/libpod/alpine_labels:latest [...] net/http: TLS handshake timeout

Looks like a registry problem on quay. I've restarted the test.

@rhatdan
Copy link
Member

rhatdan commented Oct 5, 2020

/approve
/lgtm
/hold

@openshift-ci-robot openshift-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Oct 5, 2020
@openshift-ci-robot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: rhatdan, zhangguanzhang

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci-robot openshift-ci-robot added lgtm Indicates that a PR is ready to be merged. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Oct 5, 2020
@rhatdan
Copy link
Member

rhatdan commented Oct 5, 2020

/hold cancel

@openshift-ci-robot openshift-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Oct 5, 2020
@mheon
Copy link
Member

mheon commented Oct 5, 2020

LGTM

@mheon
Copy link
Member

mheon commented Oct 5, 2020

/hold

Merge seems blocked - CI is having issues.

@openshift-ci-robot openshift-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Oct 5, 2020
@rhatdan
Copy link
Member

rhatdan commented Oct 5, 2020

@cevich PTAL

@edsantiago
Copy link
Collaborator

"Smoke" and "Total Success" are new-CI terms, not old-CI. I wonder if all PRs now need to be rebased?

@mheon
Copy link
Member

mheon commented Oct 5, 2020

Please rebase - CI should be fixed now.

@TomSweeneyRedHat
Copy link
Member

LGTM

@jwhonce
Copy link
Member

jwhonce commented Oct 6, 2020

/hold cancel

@openshift-ci-robot openshift-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Oct 6, 2020
@zhangguanzhang
fix apiv2 /containers/$name/json return wrong value in `.Config.StopS…
adde67c 
…ignal`

Signed-off-by: zhangguanzhang <zhangguanzhang@qq.com>
@openshift-ci-robot openshift-ci-robot removed the lgtm Indicates that a PR is ready to be merged. label Oct 6, 2020
@zhangguanzhang
Copy link
Collaborator Author

ci errored😥

@edsantiago
Copy link
Collaborator

/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Oct 6, 2020
@openshift-merge-robot openshift-merge-robot merged commit defb754 into containers:master Oct 6, 2020
@zhangguanzhang zhangguanzhang deleted the apiv2-wrong-StopSignal branch November 18, 2020 09:19
@github-actions github-actions bot added the locked - please file new issue/PR Assist humans wanting to comment on an old issue or PR with locked comments. label Sep 24, 2023
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Sep 24, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees

@edsantiago edsantiago

@rhatdan rhatdan

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. locked - please file new issue/PR Assist humans wanting to comment on an old issue or PR with locked comments.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[apiv2] /containers/$name/json return wrong value in .Config.StopSignal
8 participants
@zhangguanzhang @edsantiago @rhatdan @openshift-ci-robot @mheon @TomSweeneyRedHat @jwhonce @openshift-merge-robot