Fix missing options in volume's display while setting uid and gid

[zhangguanzhang]

Fixes: #8791

$ podman   volume create testvol --opt o=uid=1001,gid=1001
testvol
$ ./bin/podman   volume create testvol2 --opt o=uid=1001,gid=1001
testvol2
$ podman volume inspect --format '{{ .Options}}' testvol 
map[]
$ podman volume inspect --format '{{ .Options}}' testvol2
map[o:uid=1001,gid=1001]

Signed-off-by: zhangguanzhang zhangguanzhang@qq.com

[openshift-ci-robot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: zhangguanzhang

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [zhangguanzhang]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[zhangguanzhang]

ci failed, need re-test

[Luap99]

This would display as:

...
"Options": {
      "o": "uid=100,gid=100"
},
...

I think @sshnaidm wants

"Options": {
      "UID": 100,
      "GID": 100
},

[Luap99]

@zhangguanzhang Btw you can restart the tests if you go on the checks tab. There should be a button Re-Run for you.

[zhangguanzhang]

@zhangguanzhang Btw you can restart the tests if you go on the checks tab. There should be a button Re-Run for you.

[root@k8s-m1 ~]# docker volume create testvol --opt o=uid=1001,gid=1001 --opt type=tmpfs --opt device=tempfs 
testvol
[root@k8s-m1 ~]# docker volume inspect testvol 
[
    {
        "CreatedAt": "2020-12-21T10:58:55+08:00",
        "Driver": "local",
        "Labels": {},
        "Mountpoint": "/var/lib/docker/volumes/testvol/_data",
        "Name": "testvol",
        "Options": {
            "device": "tempfs",
            "o": "uid=1001,gid=1001",
            "type": "tmpfs"
        },
        "Scope": "local"
    }
]

[sshnaidm]

@zhangguanzhang I'd agree with @Luap99, better to have it as:

"Options": {
      "UID": 100,
      "GID": 100
},

o= is just a shortcut for option as I can understand.

thanks for working on it!

[mheon]

I think using UID and GID keys, instead of o=, is probably OK - the o= options are passed directly to the mount command with the local driver, these are not. Once I finish the volume plugin support in January, arbitrary options will also be supported there as well.

[zhangguanzhang]

all had done

[rhatdan]

LGTM

[baude]

@zhangguanzhang can you please update your commit msg to be more informative? i love the examples i'm just looking for a better intro to them? then im happy to merge.

[zhangguanzhang]

I'm on the bed, I will update it at tomorrow

[baude]

/lgtm