Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

play kube: fix args/command handling #8807

Merged
merged 1 commit into from Dec 23, 2020
Merged

play kube: fix args/command handling #8807

merged 1 commit into from Dec 23, 2020

Conversation

haircommander
Copy link
Collaborator

when neither yaml.Args nor yaml.Command are specified, we should use the entrypoint and cmd from the image.

update the tests to cover this and another case (both args and command are specified).
use the registry image instead of redis, as it has both an entrypoint and command specified.
update the documentation around this handling to hopefully prevent regressions and confusion.

fixes #8803

Signed-off-by: Peter Hunt pehunt@redhat.com

@haircommander
play kube: fix args/command handling
1c437f0 
when neither yaml.Args nor yaml.Command are specified, we should use the entrypoint and cmd from the image.

update the tests to cover this and another case (both args and command are specified).
use the registry image instead of redis, as it has both an entrypoint and command specified.
update the documentation around this handling to hopefully prevent regressions and confusion.

Signed-off-by: Peter Hunt <pehunt@redhat.com>
@haircommander haircommander mentioned this pull request Dec 22, 2020
Closed
@baude
Copy link
Member

baude commented Dec 22, 2020

lgtm

@baude
Copy link
Member

baude commented Dec 22, 2020

/approve

@openshift-ci-robot openshift-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Dec 22, 2020
@bziemons
Copy link
Contributor

bziemons commented Dec 22, 2020 •
edited

this does not use the spec's entrypoint (s.Entrypoint) at all - I am guessing that can be seen on podman inspect and that would be irritating?

PS: I am guessing it has more implications. Like signal handling.

@rhatdan
Copy link
Member

rhatdan commented Dec 22, 2020

/lgtm
/hold

@openshift-ci-robot openshift-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Dec 22, 2020
@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Dec 22, 2020
@haircommander
Copy link
Collaborator Author

this does not use the spec's entrypoint (s.Entrypoint) at all - I am guessing that can be seen on podman inspect and that would be irritating?

it seems to be a more invasive change of behavior to start using entrypoint. I'm investigating that now

@haircommander
Copy link
Collaborator Author

this does not use the spec's entrypoint (s.Entrypoint) at all - I am guessing that can be seen on podman inspect and that would be irritating?

it seems to be a more invasive change of behavior to start using entrypoint. I'm investigating that now

I will address this in a follow up, it may need more conversation

/hold cancel

@openshift-ci-robot openshift-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Dec 22, 2020
@haircommander haircommander mentioned this pull request Dec 22, 2020
Closed
@openshift-ci-robot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: baude, haircommander, zhangguanzhang

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [baude,zhangguanzhang]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@rhatdan
Copy link
Member

rhatdan commented Dec 23, 2020

Not sure what is going on here. Manually merging.

@rhatdan rhatdan merged commit 9b6324f into containers:master Dec 23, 2020
@bziemons bziemons mentioned this pull request Dec 23, 2020
Closed
This was referenced Jan 6, 2021
Closed
Closed
@AlbanBedel
Copy link
Contributor

This bug is quiet a severe break of functionality, can this PR be backported for v2.2.2?

@rhatdan
Copy link
Member

rhatdan commented Jan 15, 2021

We are doing RC1 for podman 3.0 today.

@github-actions github-actions bot added the locked - please file new issue/PR Assist humans wanting to comment on an old issue or PR with locked comments. label Sep 23, 2023
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Sep 23, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@zhangguanzhang zhangguanzhang zhangguanzhang approved these changes

Assignees

@rhatdan rhatdan

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. locked - please file new issue/PR Assist humans wanting to comment on an old issue or PR with locked comments.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

podman play kube (rootless) does not set command and args as specfied at the k8s specs
7 participants
@haircommander @baude @bziemons @rhatdan @openshift-ci-robot @AlbanBedel @zhangguanzhang