kpod create should not do an OCI Init #96
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
My only concern with this change is how it will effect kpod inspect. We need to make sure we record the information used in kpod create so inspect can be able to retrieve the data at a later time. @umohnani8 @mheon PTAL |
rhatdan
force-pushed
the
create
branch
2 times, most recently
from
4e1d1ad
to
e7beabb
Compare
mheon
reviewed
Dec 3, 2017
libpod/container.go
Outdated
| @@ -416,6 +416,10 @@ func (c *Container) Init() (err error) { | |||
| return err | |||
| } | |||
|
|
|||
| if c.state.State == ContainerStateCreated { | |||
There was a problem hiding this comment.
Can you remove this and instead ignore ErrCtrExists when doing the Init() in start.go?
We need to differentiate between a kpod create and a kpod start kpod create should create all of the data for libpod, but kpod start should generate content for OCI Runtime (runc) in order to run. Signed-off-by: Daniel J Walsh <dwalsh@redhat.com>
|
LGTM |
1 similar comment
|
LGTM |
|
LGTM |
|
📌 Commit ddc525e has been approved by |
rh-atomic-bot
pushed a commit
that referenced
this pull request
Dec 4, 2017
We need to differentiate between a kpod create and a kpod start kpod create should create all of the data for libpod, but kpod start should generate content for OCI Runtime (runc) in order to run. Signed-off-by: Daniel J Walsh <dwalsh@redhat.com> Closes: #96 Approved by: mheon
|
💔 Test failed - status-papr |
|
Looks like a flake |
|
@rh-atomic-bot retry |
|
☀️ Test successful - status-papr |
wking
added a commit
to wking/libpod
that referenced
this pull request
May 11, 2018
containernetworking/plugins@a0eac8d7 (pkg/ns: remove namespace creation, 2018-03-16) removed NewNS, which we use in libpod/networking.go. Pinning to the previous commit, containernetworking/plugins@1fb94a42 (Merge pull request containers#96 from DennisDenuto/denuto/master, 2018-03-14), allows us to run vndr without breaking our build. This is a short term fix; moving forward we'll want to either drop this dependency or catch up with the new upstream API. The upstream package seems to have been fairly stable in the meantime, because even with the new pinned version, a vndr re-vendor generates no changes: $ vndr github.com/containernetworking/plugins Signed-off-by: W. Trevor King <wking@tremily.us>
wking
added a commit
to wking/libpod
that referenced
this pull request
May 11, 2018
containernetworking/plugins@a0eac8d7 (pkg/ns: remove namespace creation, 2018-03-16) removed NewNS, which we use in libpod/networking.go. Pinning to the previous commit, containernetworking/plugins@1fb94a42 (Merge pull request containers#96 from DennisDenuto/denuto/master, 2018-03-14), allows us to run vndr without breaking our build. This is a short term fix; moving forward we'll want to either drop this dependency or catch up with the new upstream API. The upstream package seems to have been fairly stable in the meantime, because even with the new pinned version, a vndr re-vendor generates no changes: $ vndr github.com/containernetworking/plugins Signed-off-by: W. Trevor King <wking@tremily.us>
rh-atomic-bot
pushed a commit
that referenced
this pull request
May 11, 2018
containernetworking/plugins@a0eac8d7 (pkg/ns: remove namespace creation, 2018-03-16) removed NewNS, which we use in libpod/networking.go. Pinning to the previous commit, containernetworking/plugins@1fb94a42 (Merge pull request #96 from DennisDenuto/denuto/master, 2018-03-14), allows us to run vndr without breaking our build. This is a short term fix; moving forward we'll want to either drop this dependency or catch up with the new upstream API. The upstream package seems to have been fairly stable in the meantime, because even with the new pinned version, a vndr re-vendor generates no changes: $ vndr github.com/containernetworking/plugins Signed-off-by: W. Trevor King <wking@tremily.us> Closes: #751 Approved by: mheon
baude
pushed a commit
to baude/podman
that referenced
this pull request
Aug 31, 2019
plugins/meta/bandwidth: traffic shaping plugin
github-actions
bot
added
the
locked - please file new issue/PR
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We need to differentiate between a kpod create and a kpod start
kpod create should create all of the data for libpod, but kpod start should
generate content for OCI Runtime (runc) in order to run.
Signed-off-by: Daniel J Walsh dwalsh@redhat.com