Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add troubleshooting advice about the --userns option. [CI:DOCS] #9770

Closed
wants to merge 1 commit into from
Closed

Add troubleshooting advice about the --userns option. [CI:DOCS] #9770

wants to merge 1 commit into from

Conversation

jberkus
Copy link
Contributor

@jberkus jberkus commented Mar 19, 2021

While I'm at it, add a link to the troubleshooting guide into
the issue template.

Thanks @mheon for the info about userns

@openshift-ci-robot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: jberkus
To complete the pull request process, please assign edsantiago after the PR has been reviewed.
You can assign the PR to them by writing /assign @edsantiago in a comment when ready.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@mheon
Copy link
Member

mheon commented Mar 19, 2021

Gitvalidation is complaining about your commit - looks like you're missing a signoff. Can you do a git commit --amend -s to add one and re-push?

Also, you can add [CI:DOCS] to the title of your PR to avoid most of our CI checks, as this is a docs-only change.

eriksjolund
eriksjolund reviewed Mar 20, 2021
View reviewed changes
troubleshooting.md Outdated
@@ -47,6 +47,14 @@ will disable SELinux separation for the container.

$ podman run --security-opt label=disable -v ~:/home/user fedora touch /home/user/file

In cases where the container image runs as a specific, non-root user, though, the
solution is to fix the user namepsace. This would include container images such as
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

namepsace -> namespace

@jberkus jberkus changed the title Add troubleshooting advice about the --userns option. Add troubleshooting advice about the --userns option. [CI:Docs] Mar 22, 2021
@jberkus jberkus changed the title Add troubleshooting advice about the --userns option. [CI:Docs] Add troubleshooting advice about the --userns option. [CI:DOCS] Mar 22, 2021
@rhatdan
Copy link
Member

rhatdan commented Mar 23, 2021

@jberkus You need to sign your PRs.

git commit -a --amend -s
git push --force

@jberkus
Add troubleshooting advice about the --userns option.
39b3cc9 
While I'm at it, add a link to the troubleshooting guide into
the issue template.

Signed-off-by: Josh Berkus <josh@agliodbs.com>
@jberkus
Copy link
Contributor Author

jberkus commented Mar 24, 2021

PR updated.

@rhatdan
Copy link
Member

rhatdan commented Mar 24, 2021

Josh, one more change, you need to put a blank line in between your title line and the first line describing the fix. For some reason the tests see these as the same line, unless there is a blank line in between.

@jberkus
Copy link
Contributor Author

jberkus commented Mar 24, 2021

Dan: that sounds like a bug in the tests.

TomSweeneyRedHat
TomSweeneyRedHat reviewed Mar 24, 2021
View reviewed changes
.github/ISSUE_TEMPLATE.md
@@ -67,7 +67,8 @@ Briefly describe the problem you are having in a few paragraphs.
(paste your output here)
```

**Have you tested with the latest version of Podman and have you checked the Podman Troubleshooting Guide?**
**Have you tested with the latest version of Podman and have you checked the Podman Troubleshooting Guide? (https://github.com/containers/podman/blob/master/troubleshooting.md)**

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice change, I hadn't thought to add a link like this in a template....

@TomSweeneyRedHat
Copy link
Member

LGTM
once tests are hip
Thanks @jberkus !

@github-actions
Copy link

A friendly reminder that this PR had no activity for 30 days.

rhatdan pushed a commit to rhatdan/podman that referenced this pull request Apr 26, 2021
@jberkus @rhatdan
Add troubleshooting advice about the --userns option.
4034628 
Also a link to the troubleshooting guide into the issue template.

Replaces: containers#9770

Signed-off-by: Josh Berkus <josh@agliodbs.com>
Signed-off-by: Daniel J Walsh <dwalsh@redhat.com>
@rhatdan rhatdan mentioned this pull request Apr 26, 2021
Merged
@rhatdan rhatdan closed this Apr 26, 2021
rhatdan pushed a commit to rhatdan/podman that referenced this pull request Apr 26, 2021
@jberkus @rhatdan
Add troubleshooting advice about the --userns option.
c9eae75 
Also a link to the troubleshooting guide into the issue template.

Replaces: containers#9770

Signed-off-by: Josh Berkus <josh@agliodbs.com>
Signed-off-by: Daniel J Walsh <dwalsh@redhat.com>
rhatdan pushed a commit to rhatdan/podman that referenced this pull request Apr 26, 2021
@jberkus @rhatdan
Add troubleshooting advice about the --userns option.
166149b 
Also a link to the troubleshooting guide into the issue template.

Replaces: containers#9770

Signed-off-by: Josh Berkus <josh@agliodbs.com>
Signed-off-by: Daniel J Walsh <dwalsh@redhat.com>
rhatdan pushed a commit to rhatdan/podman that referenced this pull request Apr 28, 2021
@jberkus @rhatdan
Add troubleshooting advice about the --userns option.
58801ed 
Also a link to the troubleshooting guide into the issue template.

Replaces: containers#9770

Signed-off-by: Josh Berkus <josh@agliodbs.com>
Signed-off-by: Daniel J Walsh <dwalsh@redhat.com>
@github-actions github-actions bot added the locked - please file new issue/PR Assist humans wanting to comment on an old issue or PR with locked comments. label Sep 23, 2023
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Sep 23, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@eriksjolund eriksjolund eriksjolund left review comments

@TomSweeneyRedHat TomSweeneyRedHat TomSweeneyRedHat left review comments

Assignees
No one assigned
Labels
locked - please file new issue/PR Assist humans wanting to comment on an old issue or PR with locked comments. stale-pr
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@jberkus @openshift-ci-robot @mheon @rhatdan @TomSweeneyRedHat @eriksjolund