Skip to content
This repository has been archived by the owner on Feb 10, 2020. It is now read-only.

Improve packaging by using PBR #2

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

4383
Copy link

@4383 4383 commented Mar 28, 2019

PBR (Python Build Reasonableness)[1].

Overview:

  • remove python code
  • introduce meta project configuration
  • allow pypi to display readme at markdown format
  • automatize semver management based on git tag name (example 1.0.0)
  • automatize changelog generate
  • automatize authors file generate

PBR allow to automatically manage your version bumping,
your changelog, your authors file and a lot of useful
features like this.

You just have to publish a git tag and pbr generate
a version number based on the git tag name (example: 1.0.0).

It also a good practice to use setup.cfg to centralize
project configuration:

  • project meta
  • wheel
  • etc...

This commit remove python code to maintain by transform it
into configuration.

If you choose to distribute this project with pypi these
changes introduce readme displayed at markdown format compatible
with pypi.

[1] https://docs.openstack.org/pbr/latest/

Signed-off-by: Hervé Beraud hberaud@redhat.com

@4383
Copy link
Author

4383 commented Mar 28, 2019

This is the first part of the pypi automation.

After that you need to create a travis-ci account to use it to deploy by git tag push on github

PBR (Python Build Reasonableness)[1].

Overview:
- remove python code
- introduce meta project configuration
- allow pypi to display readme at markdown format
- automatize semver management based on git tag name (example 1.0.0)
- automatize changelog generate
- automatize authors file generate

PBR allow to automatically manage your version bumping,
your changelog, your authors file and a lot of useful
features like this.

You just have to publish a git tag and pbr generate
a version number based on the git tag name (example: 1.0.0).

It also a good practice to use setup.cfg to centralize
project configuration:
- project meta
- wheel
- etc...

This commit remove python code to maintain by transform it
into configuration.

If you choose to distribute this project with pypi these
changes introduce readme displayed at markdown format compatible
with pypi.

[1] https://docs.openstack.org/pbr/latest/

Signed-off-by: Hervé Beraud <hberaud@redhat.com>
@4383
Copy link
Author

4383 commented Mar 28, 2019

Also I guess you need to activate the issues for this project in the repo settings

@4383
Copy link
Author

4383 commented Apr 4, 2019

This is the first part of the pypi automation.

After that you need to create a travis-ci account to use it to deploy by git tag push on github

@4383
Copy link
Author

4383 commented Apr 16, 2019

Do you have any updates about this?

@rhatdan rhatdan requested a review from jwhonce April 17, 2019 13:29
@rhatdan
Copy link
Member

rhatdan commented Apr 17, 2019

I am fine with this, as I said in the other PR. But I would want others who might know more about PYPY to handle it.

@jwhonce @lsm5 @vrothberg PTAL

@4383 Right now we have pulled resources from working on pypodman, and are concentrating on podman-remote (Golang version). I am not sure if any engineering is going to happen in this Repo any longer.

BTW I am very interested in seeing podman-python going forward.

@4383
Copy link
Author

4383 commented May 10, 2019

@lsm5 @jwhonce @baude please can you take a look?

Thanks.

@lsm5
Copy link
Member

lsm5 commented May 10, 2019

Hi @4383 , this is unfamiliar territory to me. Is there a walkthrough on using this for rpm builds? Also, if there's no certain plans for pypodman, can you do this for python-podman repo instead?

@4383
Copy link
Author

4383 commented May 10, 2019

@lsm5 I already submit the same patch on python-podman.

Concerning the rpm builds I'm not an expert but it's a straightforward things to build an rpm from source.

@lsm5
Copy link
Member

lsm5 commented May 10, 2019

Concerning the rpm builds I'm not an expert but it's a straightforward things to build an rpm from source.

ack, in that case, I'm good to go either way if it doesn't really affect rpm workflow. I'll let the others decide on this.

@rhatdan
Copy link
Member

rhatdan commented May 10, 2019

LGTM
But I think we need @jwhonce Approval for merge.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
3 participants