Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

e2e: add markdown-cli linter #198

Merged
merged 1 commit into from
Sep 5, 2023
Merged

Conversation

dougsland
Copy link
Collaborator

Signed-off-by: Douglas Schilling Landgraf dougsland@redhat.com

Signed-off-by: Douglas Schilling Landgraf <dougsland@redhat.com>
Copy link
Collaborator

@sandrobonazzola sandrobonazzola left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is there any reason for running linting on the code during end to end tests?
I assume this should be covered by pre-commit already

@dougsland
Copy link
Collaborator Author

Is there any reason for running linting on the code during end to end tests?
I assume this should be covered by pre-commit already

@sandrobonazzola
bluechi project uses this markdown lint. Would be nice to have the same one they run there too.

https://github.com/containers/bluechi/blob/main/.github/workflows/lint.yml#L101

@dougsland
Copy link
Collaborator Author

dougsland commented Sep 5, 2023

On top of that, this is AllInOne solution, it's E2E and platform for development. If users would like to use pre-commit it's fine, others use markdown-cliv2 also fine. Some linters contain different outputs (specially markdowns) and syncing with what bluechi project has is good IMO and won't hurt.

@sandrobonazzola
Copy link
Collaborator

I won't be the one blocking this PR but IMHO if this container is going to be used for development it should live in another place, not in e2e. Having a bigger container for e2e testing means we consume more bandwidth, storage and time to run e2e testing. This consumes power and money, we should minimize the e2e test environment, not making it bigger.

@dougsland
Copy link
Collaborator Author

I won't be the one blocking this PR but IMHO if this container is going to be used for
development it should live in another place, not in e2e. Having a bigger container for e2e
testing means we consume more bandwidth, storage and time to run e2e testing. This
consumes power and money, we should minimize the e2e test environment, not making it
bigger.

Thanks Sandro! We can always improve the solution. Let's merge now, I am aware that @Yarboa is working in some improvements regarding layers/images etc. Also, fell free to create an issue in the repo with the details and improvements you visualize so we can address it.

@dougsland dougsland merged commit 603eb93 into containers:main Sep 5, 2023
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants