Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding Dennis as default reviewer #211

Merged
merged 1 commit into from
Sep 18, 2023
Merged

Conversation

Yarboa
Copy link
Collaborator

@Yarboa Yarboa commented Sep 18, 2023

No description provided.

@Yarboa Yarboa marked this pull request as draft September 18, 2023 15:26
@Yarboa Yarboa changed the title Adding Dennis as default reviewer [Do not merge] Adding Dennis as default reviewer Sep 18, 2023
Signed-off-by: Yariv Rachmani <yrachman@redhat.com>
@Yarboa Yarboa changed the title [Do not merge] Adding Dennis as default reviewer Adding Dennis as default reviewer Sep 18, 2023
@Yarboa Yarboa marked this pull request as ready for review September 18, 2023 15:34
@Yarboa
Copy link
Collaborator Author

Yarboa commented Sep 18, 2023

@dougsland there is an error that users does'nt have write permission to qm repo,
Do they need to be members of containers project?

@dougsland
Copy link
Collaborator

@dougsland there is an error that users does'nt have write permission to qm repo, Do they need to be members of containers project?

yes, I can fix that.

@dougsland
Copy link
Collaborator

@dougsland there is an error that users does'nt have write permission to qm repo, Do they need to be members of containers project?

yes, I can fix that.

sent invite to both, they need to accept.

@dougsland
Copy link
Collaborator

LGTM

@lsm5 @rhatdan PTAL

@rhatdan
Copy link
Member

rhatdan commented Sep 18, 2023

LGTM

@rhatdan rhatdan merged commit ea6b114 into containers:main Sep 18, 2023
6 checks passed
@rhatdan
Copy link
Member

rhatdan commented Sep 18, 2023

Welcome @dennisbrendel @priyverm

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants