Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

setup: make sure create rootfs req dirs #224

Merged
merged 2 commits into from
Sep 28, 2023
Merged

setup: make sure create rootfs req dirs #224

merged 2 commits into from
Sep 28, 2023

Conversation

dougsland
Copy link
Collaborator

Fixes: #223

Signed-off-by: Douglas Schilling Landgraf dougsland@redhat.com

@dougsland
setup: make sure create rootfs req dirs
99abef0 
Fixes: #223

Signed-off-by: Douglas Schilling Landgraf <dougsland@redhat.com>
@dougsland
Copy link
Collaborator Author

@rhatdan PTAL

@dougsland
setup: add rwetcfs rwvarfs skip-systemctl to list
d135979 
Fixes: #225

Signed-off-by: Douglas Schilling Landgraf <dougsland@redhat.com>
Yarboa
Yarboa previously requested changes Sep 28, 2023
View reviewed changes
Copy link
Collaborator

@Yarboa Yarboa left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Test is failing here no QM
I do not understand this fix,

What is the purpose of ignore systemctl
but it seems QM is not up, I will check it also

@rhatdan
Copy link
Member

rhatdan commented Sep 28, 2023

LGTM

@dougsland
Copy link
Collaborator Author

CI is Broken, issue not related.

@dougsland
Copy link
Collaborator Author

Test is failing here no QM I do not understand this fix,

What is the purpose of ignore systemctl but it seems QM is not up, I will check it also

This is just an issue I found in one my tests but also a "safe programming" IMHO.

@dougsland dougsland dismissed Yarboa’s stale review September 28, 2023 14:53

I don't see any request here, dismiss

@dougsland dougsland merged commit 151f842 into containers:main Sep 28, 2023
5 of 6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Yarboa Yarboa Yarboa left review comments

@rhatdan rhatdan Awaiting requested review from rhatdan rhatdan is a code owner

@lsm5 lsm5 Awaiting requested review from lsm5 lsm5 is a code owner

@sandrobonazzola sandrobonazzola Awaiting requested review from sandrobonazzola sandrobonazzola is a code owner

@dennisbrendel dennisbrendel Awaiting requested review from dennisbrendel dennisbrendel is a code owner

@priyverm priyverm Awaiting requested review from priyverm priyverm is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

setup: cp: cannot create regular file '/usr/lib/qm/rootfs/etc/containers/': Not a directory
3 participants
@dougsland @rhatdan @Yarboa