Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix using skip-systemctl with other options #238

Merged
merged 3 commits into from
Oct 9, 2023

Conversation

odra
Copy link
Collaborator

@odra odra commented Oct 9, 2023

Adds skip-systemctl, so it can work with other cli options.

Signed-off-by: Leonardo Rossetti <lrossett@redhat.com>
Signed-off-by: Leonardo Rossetti <lrossett@redhat.com>
Copy link
Collaborator

@Yarboa Yarboa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

setup Show resolved Hide resolved
Signed-off-by: Leonardo Rossetti <lrossett@redhat.com>
Yarboa added a commit to Yarboa/qm that referenced this pull request Oct 9, 2023
Resolves containers#236

Add tier-1 to packit plans
Currently autosd container is running with --privileged
Test tier-1 will fail due to bug in qm containers#238

Signed-off-by: Yariv Rachmani <yrachman@redhat.com>
@Yarboa Yarboa merged commit 32f42cc into containers:main Oct 9, 2023
6 checks passed
Yarboa added a commit to Yarboa/qm that referenced this pull request Oct 9, 2023
Resolves containers#236

Add tier-1 to packit plans
Currently autosd container is running with --privileged
Test tier-1 will fail due to bug in qm containers#238

Signed-off-by: Yariv Rachmani <yrachman@redhat.com>
Yarboa added a commit to Yarboa/qm that referenced this pull request Oct 10, 2023
Resolves containers#236

Add tier-1 to packit plans
Currently autosd container is running with --privileged
Test tier-1 will fail due to bug in qm containers#238

Signed-off-by: Yariv Rachmani <yrachman@redhat.com>
dougsland pushed a commit that referenced this pull request Oct 10, 2023
Resolves #236

Add tier-1 to packit plans
Currently autosd container is running with --privileged
Test tier-1 will fail due to bug in qm #238

Signed-off-by: Yariv Rachmani <yrachman@redhat.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants