setup: add vim #269
Merged
setup: add vim #269
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
add vim editor to the qm container Signed-off-by: Douglas Schilling Landgraf <dougsland@redhat.com>
dougsland
requested review from
rhatdan,
lsm5,
Yarboa,
sandrobonazzola,
dennisbrendel and
priyverm
as code owners
|
LGTM |
|
hm, I'm not sure we really want this. I doubt we want vim in cars and we can edit files from outside the qm partition if needed ( |
|
Perhaps we should have a separate PR for setup tests from those which we will ship. I agree we probably want to limit the potential attack surface within the QM. |
|
done: #274 |
|
On Mon, Nov 06, 2023 at 06:47:54AM -0800, Douglas Landgraf wrote:
done: #274
Thanks!
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
add vim editor to the qm container