Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adding AWS nested container fix #280

Merged
merged 2 commits into from
Nov 27, 2023
Merged

Adding AWS nested container fix #280

merged 2 commits into from
Nov 27, 2023

Conversation

Yarboa
Copy link
Collaborator

@Yarboa Yarboa commented Nov 16, 2023 •
edited
Loading

Resolve #278
This one solve other issues begun with podman4.7
this error is new

out: Error: failed to get new shm lock manager: failed to create 2048 locks in /libpod_lock: read-only file
Inside the qm

Added some changes:

Once ReadOnlyTmpfs=true will be inside podman@QM we can change this parameter
in container unit file and the test

  • Set TMPDIR in QM containers.conf to avoid diskspace is full once pulling an image

Test setup HW

  • Addition option added to prepare set-ff-env-e2e script: '--set-qm-disk-part' to create additional /var partition for qm, test need to request HW with 2 disks.
    PTAL at packit ffi tests request

@Yarboa
Adding nested container fix
37b8ecf 
Resolve containers#278

Signed-off-by: Yariv Rachmani <yrachman@redhat.com>
@Yarboa Yarboa mentioned this pull request Nov 16, 2023
Closed
dougsland
dougsland reviewed Nov 16, 2023
View reviewed changes
plans/e2e/ffi.fmf Outdated Show resolved Hide resolved
@Yarboa Yarboa changed the title Adding nested container fix Adding AWS nested container fix Nov 19, 2023
@Yarboa Yarboa marked this pull request as draft November 19, 2023 13:39
@Yarboa Yarboa force-pushed the fix-qm-tmp-dir branch 7 times, most recently from b186e41 to 67417a5 Compare November 21, 2023 15:58
@Yarboa Yarboa self-assigned this Nov 21, 2023
@Yarboa Yarboa marked this pull request as ready for review November 21, 2023 16:03
Yarboa
Yarboa commented Nov 21, 2023
View reviewed changes
Copy link
Collaborator Author

@Yarboa Yarboa left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@dougsland @rhatdan

@Yarboa Yarboa mentioned this pull request Nov 22, 2023
Merged
@Yarboa
Adding some debug option to trace mount points and its permissions
5e0273b 
Adding unit attribute to support nestes podman exec inside qm

Signed-off-by: Yariv Rachmani <yrachman@redhat.com>
@dougsland dougsland merged commit 70350ae into containers:main Nov 27, 2023
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dougsland dougsland dougsland left review comments

@rhatdan rhatdan Awaiting requested review from rhatdan rhatdan is a code owner

@lsm5 lsm5 Awaiting requested review from lsm5 lsm5 is a code owner

@sandrobonazzola sandrobonazzola Awaiting requested review from sandrobonazzola sandrobonazzola is a code owner

@dennisbrendel dennisbrendel Awaiting requested review from dennisbrendel dennisbrendel is a code owner

@priyverm priyverm Awaiting requested review from priyverm priyverm is a code owner

Assignees

@Yarboa Yarboa

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Nested image pull inside QM container id failing
2 participants
@Yarboa @dougsland