Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Handle RHEL missing vsomeip packages #329

Merged
merged 1 commit into from
Jan 25, 2024
Merged

Handle RHEL missing vsomeip packages #329

merged 1 commit into from
Jan 25, 2024

Conversation

rhatdan
Copy link
Member

@rhatdan rhatdan commented Jan 25, 2024

No description provided.

@Yarboa Yarboa changed the title Handle RHEL missing vsomeio packages Handle RHEL missing vsomeip packages Jan 25, 2024
Yarboa
Yarboa reviewed Jan 25, 2024
View reviewed changes
Copy link
Collaborator

@Yarboa Yarboa left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am not following
So, do you plan to remove the dependency of vsomeip3_selinux from build?

@dougsland dougsland added jira bug Something isn't working labels Jan 25, 2024
@rhatdan
Copy link
Member Author

rhatdan commented Jan 25, 2024

Yes.

@mwperina
Copy link
Contributor

We need to bump version to 0.6.2 and then this fix might be built successfully: https://github.com/containers/qm/blob/main/VERSION

@rhatdan
Handle RHEL missing vsomeio packages
1195085 
Signed-off-by: Daniel J Walsh <dwalsh@redhat.com>
@Yarboa Yarboa assigned Yarboa and rhatdan and unassigned Yarboa Jan 25, 2024
Yarboa
Yarboa approved these changes Jan 25, 2024
View reviewed changes
Copy link
Collaborator

@Yarboa Yarboa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@dougsland
Copy link
Collaborator

waiting CI/CD

@dougsland dougsland merged commit c6dab9e into containers:main Jan 25, 2024
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dougsland dougsland dougsland approved these changes

@Yarboa Yarboa Yarboa approved these changes

@lsm5 lsm5 Awaiting requested review from lsm5 lsm5 is a code owner

@odra odra Awaiting requested review from odra odra is a code owner

@sandrobonazzola sandrobonazzola Awaiting requested review from sandrobonazzola sandrobonazzola is a code owner

@dennisbrendel dennisbrendel Awaiting requested review from dennisbrendel dennisbrendel is a code owner

@priyverm priyverm Awaiting requested review from priyverm priyverm is a code owner

Assignees

@rhatdan rhatdan

Labels
bug Something isn't working jira
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@rhatdan @mwperina @dougsland @Yarboa