Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

seccomp: add new tool create-seccomp-rules #387

Merged
merged 1 commit into from
Apr 25, 2024
Merged

seccomp: add new tool create-seccomp-rules #387

merged 1 commit into from
Apr 25, 2024

Conversation

dougsland
Copy link
Collaborator

This patch removes the logic from setup and creates a independent tool to manage seccomp rules for QM. It should help with ostree issue.

Fixes: #385
Fixes: #375

@dougsland
Copy link
Collaborator Author

Looks like this is what we need. However, need to be tested against sample-images ostree. It's late now, should be able to test it tomorrow.

@dougsland dougsland force-pushed the seccomp-tool branch 2 times, most recently from 27c0af9 to d37c76a Compare April 25, 2024 04:04
@dougsland
Copy link
Collaborator Author

dougsland commented Apr 25, 2024 •
edited

cc @Yarboa @ericcurtin

Yarboa
Yarboa approved these changes Apr 25, 2024
View reviewed changes
Copy link
Collaborator

@Yarboa Yarboa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@dougsland dougsland force-pushed the seccomp-tool branch 2 times, most recently from 72c2e5d to ace8f7b Compare April 25, 2024 19:43
@dougsland
seccomp: add new tool create-seccomp-rules
fb7bc18 
This patch removes the logic from setup and creates a independent tool
to manage seccomp rules for QM. It should help with ostree issue.

Fixes: #385
Fixes: #375

Signed-off-by: Douglas Schilling Landgraf <dougsland@redhat.com>
Yarboa
Yarboa approved these changes Apr 25, 2024
View reviewed changes
Copy link
Collaborator

@Yarboa Yarboa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice trick
I hope it will work for ostree build also

@dougsland
Copy link
Collaborator Author

Nice trick I hope it will work for ostree build also

worked.

@dougsland
Copy link
Collaborator Author

just waiting ci/cd getting green as formal ACK but i tested ostree and regular, all good.

@dougsland dougsland merged commit b81f841 into containers:main Apr 25, 2024
7 checks passed
@dougsland dougsland mentioned this pull request Apr 27, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Yarboa Yarboa Yarboa approved these changes

@rhatdan rhatdan Awaiting requested review from rhatdan rhatdan is a code owner

@lsm5 lsm5 Awaiting requested review from lsm5 lsm5 is a code owner

@odra odra Awaiting requested review from odra odra is a code owner

@sandrobonazzola sandrobonazzola Awaiting requested review from sandrobonazzola sandrobonazzola is a code owner

@dennisbrendel dennisbrendel Awaiting requested review from dennisbrendel dennisbrendel is a code owner

@priyverm priyverm Awaiting requested review from priyverm priyverm is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
2 participants
@dougsland @Yarboa