ffi: Adding qm-omm-score-adj test #444
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
telemaco
requested review from
rhatdan,
lsm5,
dougsland,
Yarboa,
odra,
sandrobonazzola,
dennisbrendel and
priyverm
as code owners
telemaco
force-pushed
the
ffi-qm-oom-score-adj
branch
from
e025495
to
388ac97
Compare
Adding a ffi test to validate that que qm container main process runs with oom_score_adj = 500 and the qm containers processes runs with the om_score_adj = 750 by default Signed-off-by: Roberto Majadas <rmajadas@redhat.com>
telemaco
force-pushed
the
ffi-qm-oom-score-adj
branch
from
388ac97
to
398f5ef
Compare
|
Should probably be marked as closes #427 |
|
@bilelmoussaoui yes. that's correct. |
|
LGTM, |
Yarboa
approved these changes
May 27, 2024
Yarboa
reviewed
May 27, 2024
dougsland
added a commit
to dougsland/qm
that referenced
this pull request
May 28, 2024
Fixes: containers#445 See-Also: containers#444 Signed-off-by: Douglas Schilling Landgraf <dougsland@redhat.com>
This was referenced May 28, 2024
|
@telemaco Just a question, will you integrate this one into https://gitlab.com/CentOS/automotive/container-images/ffi-tools/ or should I create a github issue for another engineer look into it? cc @Yarboa as I am PTO this week. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adding a ffi test to validate that que qm container main process runs with oom_score_adj = 500 and the qm containers processes runs with the om_score_adj = 750 by default
resolve #427