-
Notifications
You must be signed in to change notification settings - Fork 757
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Integration test bucket needs: #184
Comments
I know @mtrmac was working on at least speed up the whole CI. Anyway, 1) is still probably needed while 2) I'm not sure how ok would be to work/test against something not upstreamed (fork) |
Can just leave the OCI tests in skip mode till there's an upstream fork. |
I wasn’t really working on the speed up much; so far I have experimented with a Docker Hub automated build, but that runs out of memory when compiling OpenShift 😈 So my best plan ATM is to add Re: 1), you may find #177 useful or at least inspirational, although it doesn’t work that way at the moment. I don’t have a strong opinion on 2) beyond thinking that our default setup should not refuse to work with an upstream unpatched server. Supporting a fork if we autodetect it or if we are configured to do so is in principle fine with me. |
I'd rather see a docker/distribution registry PR that fixes the hardcoded manifest tags like https://github.com/docker/distribution/blob/master/manifest/manifestlist/manifestlist.go#L14 to enable /s/.docker./.oci. Any chance one of you guys or maybe @stevvooe are working on that? |
Re #177 yes that helps.. but I was a bit perplexed by the two separate registry testing paths one for docker registry and another for the open shift (based on docker registry) registry? |
For OpenShift, we use the native API to store/retrieve signatures (and actually for uploading the manifest as well). |
Talked to stevvooe.. so I'll get started on a docker/distribution PR for the tag support. Won't have to do a fork :-) |
@mikebrow are you talking about having docker/distribution to support OCI media types? If so, probably my mistake of not telling it before, there's already a pseudo-effort to achieve this (there are some WIP branches around). |
/cc @vbatts |
@runcom Yes. If a branch exists / someone is working on it, just need a pointer. |
Sure, thx. |
I believe this is fixed, closing. Reopen if I am mistaken. |
We don’t have any integration tests against an OCI-supporting registry AFAIK. The way I read this issue, it was @mikebrow announcing what he plans to work on, though, so closing this seems reasonable. (And for the record, the support did land upstream in distribution/distribution#2076 thanks to @mikebrow ). |
I'm doing some work on the above. Comments & questions?
The text was updated successfully, but these errors were encountered: