Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Integration test bucket needs: #184

Closed
mikebrow opened this issue Sep 1, 2016 · 15 comments
Closed

Integration test bucket needs: #184

mikebrow opened this issue Sep 1, 2016 · 15 comments
Labels
help wanted kind/feature A request for, or a PR adding, new functionality locked - please file new issue/PR

Comments

@mikebrow
Copy link
Contributor

mikebrow commented Sep 1, 2016

  1. More test cases a) push & pull images using local docker registry b) see @runcom todo notes
  2. OCI test cases need to be added (OCI enabled local registry) a) using modified registry fork that enables OCI push pull.

I'm doing some work on the above. Comments & questions?

@runcom
Copy link
Member

runcom commented Sep 1, 2016

I know @mtrmac was working on at least speed up the whole CI.

Anyway, 1) is still probably needed while 2) I'm not sure how ok would be to work/test against something not upstreamed (fork)

@mikebrow
Copy link
Contributor Author

mikebrow commented Sep 1, 2016

Can just leave the OCI tests in skip mode till there's an upstream fork.

@mtrmac
Copy link
Collaborator

mtrmac commented Sep 1, 2016

I wasn’t really working on the speed up much; so far I have experimented with a Docker Hub automated build, but that runs out of memory when compiling OpenShift 😈 So my best plan ATM is to add make upload-test-base-images to Makefile, manually build them locally and upload them to a personal repository. (Or is there another hosted, automated service to rebuild Docker images on either a commit or a base image change, and to publish them into a registry, which we could easily use?)

Re: 1), you may find #177 useful or at least inspirational, although it doesn’t work that way at the moment.

I don’t have a strong opinion on 2) beyond thinking that our default setup should not refuse to work with an upstream unpatched server. Supporting a fork if we autodetect it or if we are configured to do so is in principle fine with me.

@mikebrow
Copy link
Contributor Author

mikebrow commented Sep 1, 2016

I'd rather see a docker/distribution registry PR that fixes the hardcoded manifest tags like https://github.com/docker/distribution/blob/master/manifest/manifestlist/manifestlist.go#L14 to enable /s/.docker./.oci. Any chance one of you guys or maybe @stevvooe are working on that?

@mikebrow
Copy link
Contributor Author

mikebrow commented Sep 1, 2016

Re #177 yes that helps.. but I was a bit perplexed by the two separate registry testing paths one for docker registry and another for the open shift (based on docker registry) registry?

@runcom runcom added kind/feature A request for, or a PR adding, new functionality help wanted labels Sep 2, 2016
@mtrmac
Copy link
Collaborator

mtrmac commented Sep 2, 2016

For OpenShift, we use the native API to store/retrieve signatures (and actually for uploading the manifest as well).

@mikebrow
Copy link
Contributor Author

mikebrow commented Sep 2, 2016

Talked to stevvooe.. so I'll get started on a docker/distribution PR for the tag support. Won't have to do a fork :-)

@cgwalters
Copy link
Contributor

@runcom
Copy link
Member

runcom commented Sep 2, 2016

@mikebrow are you talking about having docker/distribution to support OCI media types? If so, probably my mistake of not telling it before, there's already a pseudo-effort to achieve this (there are some WIP branches around).

@runcom
Copy link
Member

runcom commented Sep 2, 2016

/cc @vbatts

@mikebrow
Copy link
Contributor Author

mikebrow commented Sep 3, 2016

@runcom Yes. If a branch exists / someone is working on it, just need a pointer.

@runcom
Copy link
Member

runcom commented Sep 12, 2016

@mikebrow there are also @mfojtik @miminar that are going to investigate those OCI patches - could you sync up with them?

@mikebrow
Copy link
Contributor Author

Sure, thx.

@rhatdan
Copy link
Member

rhatdan commented Apr 25, 2019

I believe this is fixed, closing. Reopen if I am mistaken.

@rhatdan rhatdan closed this as completed Apr 25, 2019
@mtrmac
Copy link
Collaborator

mtrmac commented Apr 25, 2019

We don’t have any integration tests against an OCI-supporting registry AFAIK.

The way I read this issue, it was @mikebrow announcing what he plans to work on, though, so closing this seems reasonable. (And for the record, the support did land upstream in distribution/distribution#2076 thanks to @mikebrow ).

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Sep 23, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
help wanted kind/feature A request for, or a PR adding, new functionality locked - please file new issue/PR
Projects
None yet
Development

No branches or pull requests

5 participants