Docker lookaside tests #177
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mtrmac
force-pushed
the
docker-lookaside-tests
branch
from
e25d93f
to
534f51d
Compare
mtrmac
force-pushed
the
docker-lookaside-tests
branch
4 times, most recently
from
4e20411
to
6090bdb
Compare
mtrmac
force-pushed
the
docker-lookaside-tests
branch
3 times, most recently
from
6c41281
to
ab2d135
Compare
mtrmac
force-pushed
the
docker-lookaside-tests
branch
3 times, most recently
from
b0cc4a6
to
3d037bc
Compare
This will make it useful for other template files. Also rewrite it to do the edits internally instead of calling sed.
Also includes a smoke test for (skopeo delete) (really verifying the sigstore deletion).
mtrmac
force-pushed
the
docker-lookaside-tests
branch
from
3d037bc
to
fc3d809
Compare
|
After containers/image#98 , these tests now work and can be merged. |
|
@mtrmac alright, feel free to rebase if you have to and merge this then |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This includes #170 , and adds integration tests for it.
Sadly, those tests depend on something like https://github.com/mtrmac/image/tree/docker-push-to-tag to support reasonable pushing to Docker registries, and that is not really ready. (Though perhaps it could be argued that it is better than status quo already?)