Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

misleading ENTRYPOINT info in README #2134

Closed
schewara opened this issue Oct 23, 2023 · 1 comment · Fixed by #2138
Closed

misleading ENTRYPOINT info in README #2134

schewara opened this issue Oct 23, 2023 · 1 comment · Fixed by #2138
Labels
locked - please file new issue/PR

Comments

@schewara
Copy link

I just stumbled on the README, where it states:

Also, the ENTRYPOINT and the WORKDIR variables are not set within these container images, as such they default to /.

While

skopeo/contrib/skopeoimage/stable/Containerfile

Line 47 in ca00d96

ENTRYPOINT ["/usr/bin/skopeo"]

explicitly defines one, which is very confusing when someone tries to pull the container image and want's to test it out.

Therefore either the README or the Containerfile should be updated that the information is correct again.
mtrmac added a commit to mtrmac/skopeo that referenced this issue Oct 24, 2023
@mtrmac
Fix ENTRYPOINT documentation, drop others.
ac6ec12 
ENTRYPOINT was incorrectly saying that it is set to /
(which doesn't even make sense).

Stop mentioning PATH and WORKDIR in the top-level README,
typical users of the container shouldn't need to care,
and it's already somewhat implied by "built using the latest Fedora".

Fixes containers#2134.

Signed-off-by: Miloslav Trmač <mitr@redhat.com>
mtrmac added a commit to mtrmac/skopeo that referenced this issue Oct 24, 2023
@mtrmac
Fix ENTRYPOINT documentation, drop others.
761b02a 
ENTRYPOINT was incorrectly documented to be set to /
(which doesn't even make sense).

Stop mentioning PATH and WORKDIR in the top-level README,
typical users of the container shouldn't need to care,
and it's already somewhat implied by "built using the latest Fedora".

Fixes containers#2134.

Signed-off-by: Miloslav Trmač <mitr@redhat.com>
@mtrmac mtrmac mentioned this issue Oct 24, 2023
Merged
@mtrmac
Copy link
Collaborator

mtrmac commented Oct 24, 2023

Thanks for your report, #2138 should help.

mtrmac added a commit to mtrmac/skopeo that referenced this issue Oct 24, 2023
@mtrmac
Fix ENTRYPOINT documentation, drop others.
d439619 
ENTRYPOINT was incorrectly documented to be set to /
(which doesn't even make sense).

Stop mentioning PATH and WORKDIR in the top-level README,
typical users of the container shouldn't need to care,
and it's already somewhat implied by "built using the latest Fedora".

Fixes containers#2134.

Signed-off-by: Miloslav Trmač <mitr@redhat.com>
mtrmac added a commit to mtrmac/skopeo that referenced this issue Oct 25, 2023
@mtrmac
Fix ENTRYPOINT documentation, drop others.
a9c7c50 
ENTRYPOINT was incorrectly documented to be set to /
(which doesn't even make sense).

Stop mentioning PATH and WORKDIR in the top-level README,
typical users of the container shouldn't need to care,
and it's already somewhat implied by "built using the latest Fedora".

Fixes containers#2134.

Signed-off-by: Miloslav Trmač <mitr@redhat.com>
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jan 29, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
locked - please file new issue/PR
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix ENTRYPOINT documentation, drop others. mtrmac/skopeo
2 participants
@schewara @mtrmac