Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add dry-run mode to skopeo-sync #1608

Merged
merged 1 commit into from
Mar 29, 2022
Merged

Add dry-run mode to skopeo-sync #1608

merged 1 commit into from
Mar 29, 2022

Conversation

rhatdan
Copy link
Member

@rhatdan rhatdan commented Mar 28, 2022

Taking over #1459 to drive it to completion.

Signed-off-by: Ted Wexler twexler@bloomberg.net
Signed-off-by: Daniel J Walsh dwalsh@redhat.com

@rhatdan
Copy link
Member Author

rhatdan commented Mar 28, 2022

@vrothberg @mtrmac PTAL

Copy link
Member

@vrothberg vrothberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! Could you add an integration test?

cmd/skopeo/sync.go Outdated Show resolved Hide resolved
cmd/skopeo/sync.go Show resolved Hide resolved
Taking over containers#1459 to drive it to completion.

Signed-off-by: Ted Wexler <twexler@bloomberg.net>
Signed-off-by: Daniel J Walsh <dwalsh@redhat.com>
@TomSweeneyRedHat
Copy link
Member

LGTM
I'd forgotten about this one.

Copy link
Member

@vrothberg vrothberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@vrothberg vrothberg merged commit 45ed92c into containers:main Mar 29, 2022
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Sep 20, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants